Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 358993003: [Android] Switch to DeviceUtils versions of file functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/test_runner.py ('k') | build/android/pylib/perf/cache_control.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/test_runner.py
diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py
index 050985f36ff812c977daf3b39a486553aba7b782..7359c1a5ff16999d22e927134c6806c9e595aef3 100644
--- a/build/android/pylib/instrumentation/test_runner.py
+++ b/build/android/pylib/instrumentation/test_runner.py
@@ -106,7 +106,7 @@ class TestRunner(base_test_runner.BaseTestRunner):
# Make sure SD card is ready.
self.device.WaitUntilFullyBooted(timeout=20)
for p in test_data:
- self.device.old_interface.PushIfNeeded(
+ self.device.PushChangedFiles(
os.path.join(constants.DIR_SOURCE_ROOT, p),
os.path.join(self.device.GetExternalStoragePath(), p))
@@ -118,7 +118,7 @@ class TestRunner(base_test_runner.BaseTestRunner):
host_src = dst_src[1]
host_test_files_path = '%s/%s' % (constants.DIR_SOURCE_ROOT, host_src)
if os.path.exists(host_test_files_path):
- self.device.old_interface.PushIfNeeded(
+ self.device.PushChangedFiles(
host_test_files_path,
'%s/%s/%s' % (
self.device.GetExternalStoragePath(),
@@ -235,7 +235,7 @@ class TestRunner(base_test_runner.BaseTestRunner):
self.TearDownPerfMonitoring(test)
if self.coverage_dir:
- self.device.old_interface.Adb().Pull(
+ self.device.PullFile(
self.coverage_device_file, self.coverage_host_file)
self.device.RunShellCommand(
'rm -f %s' % self.coverage_device_file)
@@ -266,8 +266,9 @@ class TestRunner(base_test_runner.BaseTestRunner):
# Obtain the relevant perf data. The data is dumped to a
# JSON formatted file.
- json_string = self.device.old_interface.GetProtectedFileContents(
- '/data/data/com.google.android.apps.chrome/files/PerfTestData.txt')
+ json_string = self.device.ReadFile(
+ '/data/data/com.google.android.apps.chrome/files/PerfTestData.txt',
+ as_root=True)
if json_string:
json_string = '\n'.join(json_string)
« no previous file with comments | « build/android/pylib/gtest/test_runner.py ('k') | build/android/pylib/perf/cache_control.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698