build/android/pylib/valgrind_tools.py - Issue 358993003: [Android] Switch to DeviceUtils versions of file functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/valgrind_tools.py

Issue 358993003: [Android] Switch to DeviceUtils versions of file functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/valgrind_tools.py

diff --git a/build/android/pylib/valgrind_tools.py b/build/android/pylib/valgrind_tools.py

index 8f845fbf1e956d519d0440f769d55275b5d01332..f11ab03c68390fadfed1510ea6757548a8e8e0c4 100644

--- a/build/android/pylib/valgrind_tools.py

+++ b/build/android/pylib/valgrind_tools.py

@@ -39,7 +39,7 @@ def SetChromeTimeoutScale(device, scale):

# Delete if scale is None/0.0/1.0 since the default timeout scale is 1.0

device.RunShellCommand('rm %s' % path)

else:

- device.old_interface.SetProtectedFileContents(path, '%f' % scale)

+ device.WriteFile(path, '%f' % scale, as_root=True)

class BaseTool(object):

@@ -173,7 +173,7 @@ class ValgrindTool(BaseTool):

ValgrindTool.VGLOGS_DIR))

files = self.GetFilesForTool()

for f in files:

- self._device.old_interface.PushIfNeeded(

+ self._device.PushChangedFiles(

os.path.join(DIR_SOURCE_ROOT, f),

os.path.join(ValgrindTool.VG_DIR, os.path.basename(f)))

« no previous file with comments | « build/android/pylib/utils/reraiser_thread.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »