tools/android/adb_profile_chrome/perf_controller.py - Issue 358993003: [Android] Switch to DeviceUtils versions of file functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/adb_profile_chrome/perf_controller.py

Issue 358993003: [Android] Switch to DeviceUtils versions of file functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/android/adb_profile_chrome/chrome_controller.py ('k') | tools/memory_inspector/memory_inspector/backends/android/android_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/android/adb_profile_chrome/perf_controller.py

diff --git a/tools/android/adb_profile_chrome/perf_controller.py b/tools/android/adb_profile_chrome/perf_controller.py

index aeb29fd0eea93cfe5fc0c40539c6956e58b5f0ae..c7d573e407596c3fd6e8df2a50433b828ec4f42d 100644

--- a/tools/android/adb_profile_chrome/perf_controller.py

+++ b/tools/android/adb_profile_chrome/perf_controller.py

@@ -75,14 +75,12 @@ class _PerfProfiler(object):

raise RuntimeError('%s. Log output:\n%s' % (msg, log))

def PullResult(self, output_path):

- if not self._device.old_interface.FileExistsOnDevice(

- self._output_file.name):

+ if not self._device.FileExists(self._output_file.name):

self._FailWithLog('Perf recorded no data')

perf_profile = os.path.join(output_path,

os.path.basename(self._output_file.name))

- self._device.old_interface.PullFileFromDevice(self._output_file.name,

- perf_profile)

+ self._device.PullFile(self._output_file.name, perf_profile)

if not os.stat(perf_profile).st_size:

os.remove(perf_profile)

self._FailWithLog('Perf recorded a zero-sized file')