Consolidate some text shadow code.

Consolidate some text shadow code.

paintTextWithShadows had unused parameters, and identical logic for
constructing a text shadow draw looper existed in three places.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177111

[jbroman, 2014-06-27 13:59:36]

Just some deduplication of text shadow code. WDYT?

[Stephen Chennney, 2014-06-27 14:26:53]

I think it's great. LGTM.

[f(malita), 2014-06-27 14:29:47]

Nice cleanup, lgtm.

https://codereview.chromium.org/356123002/diff/20001/Source/core/rendering/In...
File Source/core/rendering/InlineTextBox.cpp (left):

https://codereview.chromium.org/356123002/diff/20001/Source/core/rendering/In...
Source/core/rendering/InlineTextBox.cpp:698: paintTextWithShadows(context,
rendererToUse, font, textRun, nullAtom, 0, 0, length, length, textOrigin,
boxRect, textShadow, textStrokeWidth > 0, isHorizontal());
Since we're at it, I find "rendererToUse" somewhat misleading - it's just *the*
renderer() for this RenderObject. We should drop the local altogether (and
replace it with getter calls), or at least rename it.

[jbroman, 2014-06-27 15:07:00]

https://codereview.chromium.org/356123002/diff/20001/Source/core/rendering/In...
File Source/core/rendering/InlineTextBox.cpp (left):

https://codereview.chromium.org/356123002/diff/20001/Source/core/rendering/In...
Source/core/rendering/InlineTextBox.cpp:698: paintTextWithShadows(context,
rendererToUse, font, textRun, nullAtom, 0, 0, length, length, textOrigin,
boxRect, textShadow, textStrokeWidth > 0, isHorizontal());
On 2014/06/27 14:29:47, Florin Malita wrote:
> Since we're at it, I find "rendererToUse" somewhat misleading - it's just
*the*
> renderer() for this RenderObject. We should drop the local altogether (and
> replace it with getter calls), or at least rename it.

Fair enough (for history, this variable dates back to
https://codereview.chromium.org/19697011). Changed to renderer(), since that's
just a member variable access and should be fast enough.

[jbroman, 2014-06-27 15:07:19]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2014-06-27 15:08:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbroman@chromium.org/356123002/40001

[commit-bot: I haz the power, 2014-06-27 16:15:45]

Change committed as 177111