Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19697011: Change rendering code to use RenderObject::resolveColor (Closed)

Created:
7 years, 5 months ago by eae
Modified:
7 years, 5 months ago
Reviewers:
esprehn, dglazkov, eseidel
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Visibility:
Public.

Description

Change rendering code to use RenderObject::resolveColor Change our rendering code to use RenderObject::resolveColor( colorPropertyId) instead of RenderStyle::visitedDependentColor colorPropertyId) or RenderStyle::colorProperty() directly. This is the first step towards changing currentColor resolution to be done at paint/query time instead of at style resolution time. BUG=261858 R=eseidel@chromium.org TEST=No change in functionality Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154616

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -163 lines) Patch
M Source/core/rendering/EllipsisBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 10 chunks +23 lines, -19 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderDetailsMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFieldset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerBacking.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 16 chunks +39 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 7 chunks +12 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 19 chunks +44 lines, -43 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 6 chunks +17 lines, -20 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
eae
7 years, 5 months ago (2013-07-19 01:00:42 UTC) #1
eae
7 years, 5 months ago (2013-07-19 03:45:22 UTC) #2
eseidel
lgtm A bit ugly. But if it paves the way to do currentColor the right ...
7 years, 5 months ago (2013-07-19 04:25:32 UTC) #3
dglazkov
lgtm, I think this is great. https://codereview.chromium.org/19697011/diff/2001/Source/core/rendering/InlineFlowBox.cpp File Source/core/rendering/InlineFlowBox.cpp (right): https://codereview.chromium.org/19697011/diff/2001/Source/core/rendering/InlineFlowBox.cpp#newcode1274 Source/core/rendering/InlineFlowBox.cpp:1274: RenderObject* o = ...
7 years, 5 months ago (2013-07-19 15:09:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/19697011/10001
7 years, 5 months ago (2013-07-19 15:58:17 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=143
7 years, 5 months ago (2013-07-19 20:47:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/19697011/10001
7 years, 5 months ago (2013-07-19 20:57:48 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=231
7 years, 5 months ago (2013-07-20 03:36:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/19697011/10001
7 years, 5 months ago (2013-07-20 07:07:14 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=302
7 years, 5 months ago (2013-07-20 12:03:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/19697011/10001
7 years, 5 months ago (2013-07-20 17:28:16 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=345
7 years, 5 months ago (2013-07-21 00:20:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/19697011/10001
7 years, 5 months ago (2013-07-21 19:28:59 UTC) #13
commit-bot: I haz the power
7 years, 5 months ago (2013-07-21 20:11:08 UTC) #14
Message was sent while issue was closed. 
Change committed as 154616

Powered by Google App Engine
This is Rietveld 408576698