Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken, philipj_slow
CC:
blink-reviews, shans, fs, eric.carlson_apple.com, Steve Block, rwlbuis, krit, arv+blink, blink-reviews-html_chromium.org, Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, blink-reviews-bindings_chromium.org, pdr., Eric Willigers, nessy, rjwright, philipj_slow, kouhei+svg_chromium.org, feature-media-reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, vcarbune.chromium, blink-reviews-animation_chromium.org, gasubic, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cleanup-typechecking
Project:
blink
Visibility:
Public.

Description

Drop [TypeChecking=Nullable]; deduce from attribute type instead [TypeChecking=Nullable] on a nullable attribute meant that the C++ getter wasn't called with a "bool& isNull" argument, instead the C++ value in a boolean context was used to determine nullness. This was only used for attributes where the C++ value was a pointer, and made perfect sense for such attributes. So much sense, in fact, that it makes sense to let that be the default behavior for such attributes. BUG=249598 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177126

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -153 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 5 chunks +3 lines, -8 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 2 chunks +2 lines, -5 lines 0 comments Download
M Source/bindings/tests/idls/TestSpecialOperations.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 11 chunks +27 lines, -119 lines 0 comments Download
M Source/core/animation/AnimationNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/FocusEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/MessageEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/MouseEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/UIEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/MediaKeyEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/storage/StorageEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jens Widell
PTAL Final step in killing [TypeChecking=Nullable]; depends on https://codereview.chromium.org/356843007/ first removing all the other (pointless) ...
6 years, 5 months ago (2014-06-27 13:58:53 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-06-27 14:02:46 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-06-27 15:16:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/352643005/1
6 years, 5 months ago (2014-06-27 15:17:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 15:17:21 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/bindings/tests/idls/TestObject.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-06-27 15:17:22 UTC) #6
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-06-27 15:47:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/352643005/20001
6 years, 5 months ago (2014-06-27 15:48:20 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-27 16:58:33 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 20:32:17 UTC) #10
Message was sent while issue was closed.
Change committed as 177126

Powered by Google App Engine
This is Rietveld 408576698