Drop [TypeChecking=Nullable]; deduce from attribute type instead

Drop [TypeChecking=Nullable]; deduce from attribute type instead

[TypeChecking=Nullable] on a nullable attribute meant that the C++ getter
wasn't called with a "bool& isNull" argument, instead the C++ value in a
boolean context was used to determine nullness.

This was only used for attributes where the C++ value was a pointer, and
made perfect sense for such attributes. So much sense, in fact, that it
makes sense to let that be the default behavior for such attributes.

BUG=249598
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177126

[Jens Widell, 2014-06-27 13:58:53]

PTAL

Final step in killing [TypeChecking=Nullable]; depends on
https://codereview.chromium.org/356843007/ first removing all the other
(pointless) uses of it.

[haraken, 2014-06-27 14:02:46]

LGTM

[Jens Widell, 2014-06-27 15:16:01]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-06-27 15:17:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/352643005/1

[commit-bot: I haz the power, 2014-06-27 15:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-27 15:17:22]

Failed to apply patch for Source/bindings/tests/idls/TestObject.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/idls/TestObject.idl
  Hunk #2 FAILED at 511.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/bindings/tests/idls/TestObject.idl.rej

Patch:       Source/bindings/tests/idls/TestObject.idl
Index: Source/bindings/tests/idls/TestObject.idl
diff --git a/Source/bindings/tests/idls/TestObject.idl
b/Source/bindings/tests/idls/TestObject.idl
index
4b8959307ac32b654437ef538d95938a628f2b05..7f3025eb1c6a07d4e4ed2f039a4c9d07d63771ea
100644
--- a/Source/bindings/tests/idls/TestObject.idl
+++ b/Source/bindings/tests/idls/TestObject.idl
@@ -246,10 +246,9 @@ interface TestObject {
     [TreatReturnedNullStringAs=Undefined] attribute ByteString
treatReturnedNullStringAsUndefinedByteStringAttribute;
     [TreatReturnedNullStringAs=Null] attribute ScalarValueString
treatReturnedNullStringAsNullScalarValueStringAttribute;
     [TreatReturnedNullStringAs=Undefined] attribute ScalarValueString
treatReturnedNullStringAsUndefinedScalarValueStringAttribute;
-    [TypeChecking=Interface|Nullable] attribute float
typeCheckingInterfaceNullableStringFloatAttribute; // nop for non-interface
types
+    [TypeChecking=Interface] attribute float
typeCheckingInterfaceFloatAttribute; // nop for non-interface types
     [TypeChecking=Interface] attribute TestInterface
typeCheckingInterfaceTestInterfaceAttribute;
-    [TypeChecking=Nullable] attribute TestInterface?
typeCheckingNullableTestInterfaceOrNullAttribute;
-    [TypeChecking=Interface|Nullable] attribute TestInterface?
typeCheckingInterfaceNullableTestInterfaceOrNullAttribute;
+    [TypeChecking=Interface] attribute TestInterface?
typeCheckingInterfaceTestInterfaceOrNullAttribute;
     [Reflect, URL] attribute DOMString urlStringAttribute;
     [Reflect=reflectUrlAttribute, URL] attribute DOMString urlStringAttribute;
     [Unforgeable] attribute long unforgeableLongAttribute;
@@ -512,8 +511,6 @@ interface TestObject {
     [TreatReturnedNullStringAs=Null] ScalarValueString
treatReturnedNullStringAsNullScalarValueStringMethod();
     [TreatReturnedNullStringAs=Undefined] ScalarValueString
treatReturnedNullStringAsUndefinedScalarValueStringMethod();
     [TypeChecking=Interface] void
typeCheckingInterfaceVoidMethodTestInterfaceEmptyArg(TestInterfaceEmpty
testInterfaceEmptyArg);
-    [TypeChecking=Nullable] void
typeCheckingNullableVoidMethodTestInterfaceEmptyOrNullArg(TestInterfaceEmpty?
testInterfaceEmptyOrNullArg);
-    [TypeChecking=Interface|Nullable] void
typeCheckingInterfaceNullableVoidMethodTestInterfaceEmptyOrNullArg(TestInterfaceEmpty?
testInterfaceEmptyOrNullArg);
     [TypeChecking=Unrestricted] void
typeCheckingUnrestrictedVoidMethodFloatArgDoubleArg(float floatArg, double
doubleArg);
     [Unforgeable] void unforgeableVoidMethod();
     void
voidMethodTestInterfaceGarbageCollectedSequenceArg(sequence<TestInterfaceGarbageCollected>
testInterfaceGarbageCollectedSequenceArg);

[Jens Widell, 2014-06-27 15:47:05]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-06-27 15:48:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/352643005/20001

[commit-bot: I haz the power, 2014-06-27 16:58:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14139)

[commit-bot: I haz the power, 2014-06-27 20:32:17]

Change committed as 177126