Source/core/events/MessageEvent.h - Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/MessageEvent.h

Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup-typechecking

Patch Set: rebased Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/events/MessageEvent.h

diff --git a/Source/core/events/MessageEvent.h b/Source/core/events/MessageEvent.h

index cae88b150aaef12248f078d01c8a2e6f2fb489a2..95d1d9b4e6c71dd3c3eb63d4b1e065ccad9d6781 100644

--- a/Source/core/events/MessageEvent.h

+++ b/Source/core/events/MessageEvent.h

@@ -86,7 +86,6 @@ public:

const String& origin() const { return m_origin; }

const String& lastEventId() const { return m_lastEventId; }

EventTarget* source() const { return m_source.get(); }

- EventTarget* source(bool& isNull) const { isNull = !m_source; return m_source.get(); }

MessagePortArray ports() const { return m_ports ? *m_ports : MessagePortArray(); }

MessagePortChannelArray* channels() const { return m_channels ? m_channels.get() : 0; }

« no previous file with comments | « Source/core/events/FocusEvent.h ('k') | Source/core/events/MouseEvent.h » ('j') | no next file with comments »