Source/bindings/tests/idls/TestSpecialOperations.idl - Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/TestSpecialOperations.idl

Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup-typechecking

Patch Set: rebased Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/idls/TestObject.idl ('k') | Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/idls/TestSpecialOperations.idl

diff --git a/Source/bindings/tests/idls/TestSpecialOperations.idl b/Source/bindings/tests/idls/TestSpecialOperations.idl

index 2e26771e2f0124ad3fa943af5e69c0da4cd0e676..0f3c2de1774442f95cead84cffcabb442cdd4d10 100644

--- a/Source/bindings/tests/idls/TestSpecialOperations.idl

+++ b/Source/bindings/tests/idls/TestSpecialOperations.idl

@@ -5,8 +5,8 @@

[

OverrideBuiltins,

] interface TestSpecialOperations {

- // [ImplementedAs], [TypeChecking=Interface|Nullable], union return, nullability

+ // [ImplementedAs], [TypeChecking=Interface], union return, nullability

// [OverrideBuiltins] affects named property operations

[ImplementedAs=getItem] getter (Node or NodeList) namedItem(DOMString name);

- [TypeChecking=Interface|Nullable] setter Node (DOMString name, Node? value);

+ [TypeChecking=Interface] setter Node (DOMString name, Node? value);

};

« no previous file with comments | « Source/bindings/tests/idls/TestObject.idl ('k') | Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp » ('j') | no next file with comments »