Source/bindings/templates/attributes.cpp - Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup-typechecking

Patch Set: rebased Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index 3bff81c74ef70a0ea81c69c38fff6f557c3e6050..38d047971442fef63ec107232ee2ddbb9216557a 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -45,7 +45,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info

attribute.is_getter_raises_exception %}

ExceptionState exceptionState(ExceptionState::GetterContext, "{{attribute.name}}", "{{interface_name}}", holder, info.GetIsolate());

{% endif %}

- {% if attribute.is_nullable and not attribute.has_type_checking_nullable %}

+ {% if attribute.is_nullable and not attribute.is_nullable_simple %}

bool isNull = false;

{% endif %}

{% if attribute.cpp_value_original %}

@@ -70,7 +70,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info

| indent}}

{% endif %}

{% if attribute.is_nullable %}

- {% if attribute.has_type_checking_nullable %}

+ {% if attribute.is_nullable_simple %}

if (!{{attribute.cpp_value}}) {

{% else %}

if (isNull) {

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/idls/TestInterface.idl » ('j') | no next file with comments »