Source/core/html/HTMLMediaElement.idl - Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.idl

Issue 352643005: Drop [TypeChecking=Nullable]; deduce from attribute type instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup-typechecking

Patch Set: rebased Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.idl

diff --git a/Source/core/html/HTMLMediaElement.idl b/Source/core/html/HTMLMediaElement.idl

index 3d87a591ba3918c6f558d978f50760c41452c5bb..1dab7aab6789cba07fd3390329ab46d1828c6fda 100644

--- a/Source/core/html/HTMLMediaElement.idl

+++ b/Source/core/html/HTMLMediaElement.idl

@@ -30,7 +30,7 @@

] interface HTMLMediaElement : HTMLElement {

// error state

- [TypeChecking=Interface|Nullable] readonly attribute MediaError? error;

+ readonly attribute MediaError? error;

// network state

[Reflect, URL, LogActivity=SetterOnly] attribute DOMString src;

@@ -73,7 +73,7 @@

// media controller

[RuntimeEnabled=MediaController, Reflect] attribute DOMString mediaGroup;

- [RuntimeEnabled=MediaController, TypeChecking=Interface|Nullable] attribute MediaController? controller;

+ [RuntimeEnabled=MediaController, TypeChecking=Interface] attribute MediaController? controller;

// controls

attribute boolean controls;

« no previous file with comments | « Source/core/events/UIEvent.h ('k') | Source/core/html/MediaKeyEvent.h » ('j') | no next file with comments »