Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 342283005: Make collection caching code more consistent (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Make collection caching code more consistent Make collection caching code more consistent by: - Moving ensureCachedHTMLCollection() from Document and Element to ContainerNode and renaming it to ensureCachedCollection(). - Make ensureCachedCollection() templated to avoid if checks on the type in the implementation and to avoid casting the return value at the call sites. - Use ensureCachedCollection() more consistently in the code base. Half the code was calling NodeListsNodeData::addCache<>() directly. R=esprehn@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179267

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase and minimize diff #

Patch Set 4 : Stop including NodeListsNodeData.h in ContainerNode.h #

Total comments: 2

Patch Set 5 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -62 lines) Patch
M Source/core/dom/ContainerNode.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 3 4 4 chunks +12 lines, -7 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 2 chunks +10 lines, -15 lines 0 comments Download
M Source/core/dom/Element.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 1 chunk +0 lines, -23 lines 0 comments Download
M Source/core/dom/NodeListsNodeData.h View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDataListElement.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLMapElement.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/LabelableElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Inactive
6 years, 6 months ago (2014-06-20 21:20:14 UTC) #1
Inactive
Post-holiday ping :)
6 years, 5 months ago (2014-07-09 12:31:01 UTC) #2
Inactive
On 2014/07/09 12:31:01, Chris Dumez wrote: > Post-holiday ping :) I split the NodeListsNodeData move ...
6 years, 5 months ago (2014-07-14 15:40:46 UTC) #3
Inactive
Ping review, I simplified the patch a bit so that we no longer need to ...
6 years, 5 months ago (2014-07-23 20:10:47 UTC) #4
Inactive
ping review.
6 years, 4 months ago (2014-07-30 20:41:02 UTC) #5
adamk
lgtm % nit https://codereview.chromium.org/342283005/diff/60001/Source/core/dom/NodeListsNodeData.h File Source/core/dom/NodeListsNodeData.h (right): https://codereview.chromium.org/342283005/diff/60001/Source/core/dom/NodeListsNodeData.h#newcode252 Source/core/dom/NodeListsNodeData.h:252: PassRefPtrWillBeRawPtr<Collection> ContainerNode::ensureCachedCollection(CollectionType type, const AtomicString& namespaceURI, ...
6 years, 4 months ago (2014-07-30 20:54:04 UTC) #6
Inactive
https://codereview.chromium.org/342283005/diff/60001/Source/core/dom/NodeListsNodeData.h File Source/core/dom/NodeListsNodeData.h (right): https://codereview.chromium.org/342283005/diff/60001/Source/core/dom/NodeListsNodeData.h#newcode252 Source/core/dom/NodeListsNodeData.h:252: PassRefPtrWillBeRawPtr<Collection> ContainerNode::ensureCachedCollection(CollectionType type, const AtomicString& namespaceURI, const AtomicString& localName) ...
6 years, 4 months ago (2014-07-30 21:03:46 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-30 21:04:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/342283005/80001
6 years, 4 months ago (2014-07-30 21:04:29 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-30 22:29:07 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 23:16:56 UTC) #11
Message was sent while issue was closed. 
Change committed as 179267

Powered by Google App Engine
This is Rietveld 408576698