Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: Source/core/html/HTMLTableElement.cpp

Issue 342283005: Make collection caching code more consistent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/HTMLTableRowElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 18 matching lines...) Expand all
29 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 29 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
30 #include "core/CSSPropertyNames.h" 30 #include "core/CSSPropertyNames.h"
31 #include "core/CSSValueKeywords.h" 31 #include "core/CSSValueKeywords.h"
32 #include "core/HTMLNames.h" 32 #include "core/HTMLNames.h"
33 #include "core/css/CSSImageValue.h" 33 #include "core/css/CSSImageValue.h"
34 #include "core/css/CSSValuePool.h" 34 #include "core/css/CSSValuePool.h"
35 #include "core/css/StylePropertySet.h" 35 #include "core/css/StylePropertySet.h"
36 #include "core/dom/Attribute.h" 36 #include "core/dom/Attribute.h"
37 #include "core/dom/ElementTraversal.h" 37 #include "core/dom/ElementTraversal.h"
38 #include "core/dom/ExceptionCode.h" 38 #include "core/dom/ExceptionCode.h"
39 #include "core/dom/NodeListsNodeData.h"
39 #include "core/frame/UseCounter.h" 40 #include "core/frame/UseCounter.h"
40 #include "core/html/HTMLTableCaptionElement.h" 41 #include "core/html/HTMLTableCaptionElement.h"
41 #include "core/html/HTMLTableCellElement.h" 42 #include "core/html/HTMLTableCellElement.h"
42 #include "core/html/HTMLTableRowElement.h" 43 #include "core/html/HTMLTableRowElement.h"
43 #include "core/html/HTMLTableRowsCollection.h" 44 #include "core/html/HTMLTableRowsCollection.h"
44 #include "core/html/HTMLTableSectionElement.h" 45 #include "core/html/HTMLTableSectionElement.h"
45 #include "core/html/parser/HTMLParserIdioms.h" 46 #include "core/html/parser/HTMLParserIdioms.h"
46 #include "core/rendering/RenderTable.h" 47 #include "core/rendering/RenderTable.h"
47 #include "platform/weborigin/Referrer.h" 48 #include "platform/weborigin/Referrer.h"
48 #include "wtf/StdLibExtras.h" 49 #include "wtf/StdLibExtras.h"
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
551 return name == backgroundAttr || HTMLElement::hasLegalLinkAttribute(name); 552 return name == backgroundAttr || HTMLElement::hasLegalLinkAttribute(name);
552 } 553 }
553 554
554 const QualifiedName& HTMLTableElement::subResourceAttributeName() const 555 const QualifiedName& HTMLTableElement::subResourceAttributeName() const
555 { 556 {
556 return backgroundAttr; 557 return backgroundAttr;
557 } 558 }
558 559
559 PassRefPtrWillBeRawPtr<HTMLTableRowsCollection> HTMLTableElement::rows() 560 PassRefPtrWillBeRawPtr<HTMLTableRowsCollection> HTMLTableElement::rows()
560 { 561 {
561 return toHTMLTableRowsCollection(ensureCachedHTMLCollection(TableRows).get() ); 562 return ensureCachedCollection<HTMLTableRowsCollection>(TableRows);
562 } 563 }
563 564
564 PassRefPtrWillBeRawPtr<HTMLCollection> HTMLTableElement::tBodies() 565 PassRefPtrWillBeRawPtr<HTMLCollection> HTMLTableElement::tBodies()
565 { 566 {
566 return ensureCachedHTMLCollection(TableTBodies); 567 return ensureCachedCollection<HTMLCollection>(TableTBodies);
567 } 568 }
568 569
569 const AtomicString& HTMLTableElement::rules() const 570 const AtomicString& HTMLTableElement::rules() const
570 { 571 {
571 return getAttribute(rulesAttr); 572 return getAttribute(rulesAttr);
572 } 573 }
573 574
574 const AtomicString& HTMLTableElement::summary() const 575 const AtomicString& HTMLTableElement::summary() const
575 { 576 {
576 return getAttribute(summaryAttr); 577 return getAttribute(summaryAttr);
577 } 578 }
578 579
579 void HTMLTableElement::trace(Visitor* visitor) 580 void HTMLTableElement::trace(Visitor* visitor)
580 { 581 {
581 visitor->trace(m_sharedCellStyle); 582 visitor->trace(m_sharedCellStyle);
582 HTMLElement::trace(visitor); 583 HTMLElement::trace(visitor);
583 } 584 }
584 585
585 } 586 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/HTMLTableRowElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698