Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: Source/core/html/HTMLFieldSetElement.cpp

Issue 342283005: Make collection caching code more consistent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLDataListElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
11 * version 2 of the License, or (at your option) any later version. 11 * version 2 of the License, or (at your option) any later version.
12 * 12 *
13 * This library is distributed in the hope that it will be useful, 13 * This library is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 * Library General Public License for more details. 16 * Library General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU Library General Public License 18 * You should have received a copy of the GNU Library General Public License
19 * along with this library; see the file COPYING.LIB. If not, write to 19 * along with this library; see the file COPYING.LIB. If not, write to
20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
21 * Boston, MA 02110-1301, USA. 21 * Boston, MA 02110-1301, USA.
22 * 22 *
23 */ 23 */
24 24
25 #include "config.h" 25 #include "config.h"
26 #include "core/html/HTMLFieldSetElement.h" 26 #include "core/html/HTMLFieldSetElement.h"
27 27
28 #include "core/HTMLNames.h" 28 #include "core/HTMLNames.h"
29 #include "core/dom/ElementTraversal.h" 29 #include "core/dom/ElementTraversal.h"
30 #include "core/dom/NodeListsNodeData.h"
30 #include "core/html/HTMLCollection.h" 31 #include "core/html/HTMLCollection.h"
31 #include "core/html/HTMLFormControlsCollection.h" 32 #include "core/html/HTMLFormControlsCollection.h"
32 #include "core/html/HTMLLegendElement.h" 33 #include "core/html/HTMLLegendElement.h"
33 #include "core/html/HTMLObjectElement.h" 34 #include "core/html/HTMLObjectElement.h"
34 #include "core/rendering/RenderFieldset.h" 35 #include "core/rendering/RenderFieldset.h"
35 #include "wtf/StdLibExtras.h" 36 #include "wtf/StdLibExtras.h"
36 37
37 namespace blink { 38 namespace blink {
38 39
39 using namespace HTMLNames; 40 using namespace HTMLNames;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 return new RenderFieldset(this); 95 return new RenderFieldset(this);
95 } 96 }
96 97
97 HTMLLegendElement* HTMLFieldSetElement::legend() const 98 HTMLLegendElement* HTMLFieldSetElement::legend() const
98 { 99 {
99 return Traversal<HTMLLegendElement>::firstChild(*this); 100 return Traversal<HTMLLegendElement>::firstChild(*this);
100 } 101 }
101 102
102 PassRefPtrWillBeRawPtr<HTMLFormControlsCollection> HTMLFieldSetElement::elements () 103 PassRefPtrWillBeRawPtr<HTMLFormControlsCollection> HTMLFieldSetElement::elements ()
103 { 104 {
104 return toHTMLFormControlsCollection(ensureCachedHTMLCollection(FormControls) .get()); 105 return ensureCachedCollection<HTMLFormControlsCollection>(FormControls);
105 } 106 }
106 107
107 void HTMLFieldSetElement::refreshElementsIfNeeded() const 108 void HTMLFieldSetElement::refreshElementsIfNeeded() const
108 { 109 {
109 uint64_t docVersion = document().domTreeVersion(); 110 uint64_t docVersion = document().domTreeVersion();
110 if (m_documentVersion == docVersion) 111 if (m_documentVersion == docVersion)
111 return; 112 return;
112 113
113 m_documentVersion = docVersion; 114 m_documentVersion = docVersion;
114 115
(...skipping 12 matching lines...) Expand all
127 } 128 }
128 } 129 }
129 130
130 const FormAssociatedElement::List& HTMLFieldSetElement::associatedElements() con st 131 const FormAssociatedElement::List& HTMLFieldSetElement::associatedElements() con st
131 { 132 {
132 refreshElementsIfNeeded(); 133 refreshElementsIfNeeded();
133 return m_associatedElements; 134 return m_associatedElements;
134 } 135 }
135 136
136 } // namespace 137 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLDataListElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698