Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Side by Side Diff: Source/core/html/HTMLTableRowElement.cpp

Issue 342283005: Make collection caching code more consistent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLTableElement.cpp ('k') | Source/core/html/HTMLTableSectionElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserv ed. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserv ed.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 11 matching lines...) Expand all
22 * Boston, MA 02110-1301, USA. 22 * Boston, MA 02110-1301, USA.
23 */ 23 */
24 24
25 #include "config.h" 25 #include "config.h"
26 #include "core/html/HTMLTableRowElement.h" 26 #include "core/html/HTMLTableRowElement.h"
27 27
28 #include "bindings/core/v8/ExceptionState.h" 28 #include "bindings/core/v8/ExceptionState.h"
29 #include "core/HTMLNames.h" 29 #include "core/HTMLNames.h"
30 #include "core/dom/ElementTraversal.h" 30 #include "core/dom/ElementTraversal.h"
31 #include "core/dom/ExceptionCode.h" 31 #include "core/dom/ExceptionCode.h"
32 #include "core/dom/NodeListsNodeData.h"
32 #include "core/html/HTMLCollection.h" 33 #include "core/html/HTMLCollection.h"
33 #include "core/html/HTMLTableCellElement.h" 34 #include "core/html/HTMLTableCellElement.h"
34 #include "core/html/HTMLTableElement.h" 35 #include "core/html/HTMLTableElement.h"
35 #include "core/html/HTMLTableSectionElement.h" 36 #include "core/html/HTMLTableSectionElement.h"
36 37
37 namespace blink { 38 namespace blink {
38 39
39 using namespace HTMLNames; 40 using namespace HTMLNames;
40 41
41 inline HTMLTableRowElement::HTMLTableRowElement(Document& document) 42 inline HTMLTableRowElement::HTMLTableRowElement(Document& document)
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 if (index >= 0 && index < numCells) { 149 if (index >= 0 && index < numCells) {
149 RefPtrWillBeRawPtr<Element> cell = children->item(index); 150 RefPtrWillBeRawPtr<Element> cell = children->item(index);
150 HTMLElement::removeChild(cell.get(), exceptionState); 151 HTMLElement::removeChild(cell.get(), exceptionState);
151 } else { 152 } else {
152 exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(index) + ") is outside the range [0, " + String::number(numCell s) + ")."); 153 exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(index) + ") is outside the range [0, " + String::number(numCell s) + ").");
153 } 154 }
154 } 155 }
155 156
156 PassRefPtrWillBeRawPtr<HTMLCollection> HTMLTableRowElement::cells() 157 PassRefPtrWillBeRawPtr<HTMLCollection> HTMLTableRowElement::cells()
157 { 158 {
158 return ensureCachedHTMLCollection(TRCells); 159 return ensureCachedCollection<HTMLCollection>(TRCells);
159 } 160 }
160 161
161 } 162 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLTableElement.cpp ('k') | Source/core/html/HTMLTableSectionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698