Make collection caching code more consistent

Source/core/dom/NodeListsNodeData.h

 /*
  * Copyright (C) 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 David Smith <catfish.man@gmail.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 218 matching lines @@
 inline bool NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList(Node& ownerNode)
 {
     ASSERT(ownerNode.nodeLists() == this);
     if ((m_childNodeList ? 1 : 0) + m_atomicNameCaches.size() + m_tagCollectionCacheNS.size() != 1)
         return false;
     ownerNode.clearNodeLists();
     return true;
 }
 #endif
 
+template <typename Collection>
+inline PassRefPtrWillBeRawPtr<Collection> ContainerNode::ensureCachedCollection(CollectionType type)
+{
+    return ensureNodeLists().addCache<Collection>(*this, type);
+}
+
+template <typename Collection>
+inline PassRefPtrWillBeRawPtr<Collection> ContainerNode::ensureCachedCollection(CollectionType type, const AtomicString& name)
+{
+    return ensureNodeLists().addCache<Collection>(*this, type, name);
+}
+
+template <typename Collection>
+PassRefPtrWillBeRawPtr<Collection> ContainerNode::ensureCachedCollection(CollectionType type, const AtomicString& namespaceURI, const AtomicString& localName)

[adamk, 2014/07/30 20:54:04]

Missing inline?

[Inactive, 2014/07/30 21:03:46]

Done.

+{
+    ASSERT_UNUSED(type, type == TagCollectionType);
+    return ensureNodeLists().addCache(*this, namespaceURI, localName);
+}
+
+template <typename Collection>
+inline Collection* ContainerNode::cachedCollection(CollectionType type)
+{
+    NodeListsNodeData* nodeLists = this->nodeLists();
+    return nodeLists ? nodeLists->cached<Collection>(type) : 0;
+}
+
 } // namespace blink
 
 #endif // NodeListsNodeData_h