Oilpan: move platform speech objects to the heap.

Oilpan: move platform speech objects to the heap.

With the Speech API now using Oilpan by default, follow up and also
heap allocate the platform-level intermediary objects.

R=tkent@chromium.org,haraken@chromium.org
BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176321

[sof, 2014-06-17 08:47:31]

Please take a look.

With the Speech API now settled with Oilpan enabled, follow up and also move the
smaller, "platform-level" (is there a more appropriate name?) objects to the
heap.

[tkent, 2014-06-17 09:06:35]

lgtm

[haraken, 2014-06-17 09:18:50]

LGTM

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
File Source/modules/speech/SpeechRecognition.h (right):

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
Source/modules/speech/SpeechRecognition.h:113: SpeechRecognitionController*
m_controller;

SpeechRecognitionController is on-heap, so can we use a Member for this?

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
File Source/modules/speech/SpeechSynthesis.h (left):

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
Source/modules/speech/SpeechSynthesis.h:46:
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SpeechSynthesis);

I'm a bit confused with this. You didn't drop WILL_BE_ from SpeechRecognition,
but dropped WILL_BE_ from SpeechSynthesis. What's the difference?

https://codereview.chromium.org/339823003/diff/20001/Source/platform/exported...
File Source/platform/exported/WebSpeechSynthesizerClientImpl.h (right):

https://codereview.chromium.org/339823003/diff/20001/Source/platform/exported...
Source/platform/exported/WebSpeechSynthesizerClientImpl.h:42: explicit
WebSpeechSynthesizerClientImpl(PlatformSpeechSynthesizer*,
PlatformSpeechSynthesizerClient*);

Drop explicit.

[sof, 2014-06-17 09:26:08]

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
File Source/modules/speech/SpeechRecognition.h (right):

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
Source/modules/speech/SpeechRecognition.h:113: SpeechRecognitionController*
m_controller;
On 2014/06/17 09:18:50, haraken wrote:
> 
> SpeechRecognitionController is on-heap, so can we use a Member for this?

Not always, but yes, will tidy this up.

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
File Source/modules/speech/SpeechSynthesis.h (left):

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
Source/modules/speech/SpeechSynthesis.h:46:
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SpeechSynthesis);
On 2014/06/17 09:18:50, haraken wrote:
> 
> I'm a bit confused with this. You didn't drop WILL_BE_ from SpeechRecognition,
> but dropped WILL_BE_ from SpeechSynthesis. What's the difference?

PlatformSpeechSynthesizerClient is on the heap always, hence needed.

SpeechRecognition is optionally a mixin due to EventTarget* being
WillBeGarbageCollectedMixin.

[haraken, 2014-06-17 09:30:23]

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
File Source/modules/speech/SpeechSynthesis.h (left):

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
Source/modules/speech/SpeechSynthesis.h:46:
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SpeechSynthesis);
On 2014/06/17 09:26:08, sof wrote:
> On 2014/06/17 09:18:50, haraken wrote:
> > 
> > I'm a bit confused with this. You didn't drop WILL_BE_ from
SpeechRecognition,
> > but dropped WILL_BE_ from SpeechSynthesis. What's the difference?
> 
> PlatformSpeechSynthesizerClient is on the heap always, hence needed.
> 
> SpeechRecognition is optionally a mixin due to EventTarget* being
> WillBeGarbageCollectedMixin.

Makes sense. If either of mixins is on the heap always, we need to drop the
WILL_BE_. Otherwise, we can leave the WILL_BE_ as is (it's also OK to drop it).

[sof, 2014-06-17 10:42:09]

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
File Source/modules/speech/SpeechRecognition.h (right):

https://codereview.chromium.org/339823003/diff/20001/Source/modules/speech/Sp...
Source/modules/speech/SpeechRecognition.h:113: SpeechRecognitionController*
m_controller;
On 2014/06/17 09:26:07, sof wrote:
> On 2014/06/17 09:18:50, haraken wrote:
> > 
> > SpeechRecognitionController is on-heap, so can we use a Member for this?
> 
> Not always, but yes, will tidy this up.

Well spotted - it's a straight bug (and not just a tracing 'nicety') with
enable_oilpan=1 not to do so, I think. Now done.

https://codereview.chromium.org/339823003/diff/20001/Source/platform/exported...
File Source/platform/exported/WebSpeechSynthesizerClientImpl.h (right):

https://codereview.chromium.org/339823003/diff/20001/Source/platform/exported...
Source/platform/exported/WebSpeechSynthesizerClientImpl.h:42: explicit
WebSpeechSynthesizerClientImpl(PlatformSpeechSynthesizer*,
PlatformSpeechSynthesizerClient*);
On 2014/06/17 09:18:50, haraken wrote:
> 
> Drop explicit.

Now gone.

[sof, 2014-06-17 10:42:35]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-06-17 10:43:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/339823003/40001

[commit-bot: I haz the power, 2014-06-17 12:39:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 12:39:10]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[sof, 2014-06-17 12:40:11]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-06-17 12:41:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/339823003/40001

[commit-bot: I haz the power, 2014-06-17 14:34:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 14:34:28]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[sof, 2014-06-17 14:35:41]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-06-17 14:35:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/339823003/40001

[commit-bot: I haz the power, 2014-06-17 15:34:43]

Change committed as 176321