Source/modules/speech/SpeechSynthesisUtterance.cpp - Issue 339823003: Oilpan: move platform speech objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/SpeechSynthesisUtterance.cpp

Issue 339823003: Oilpan: move platform speech objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Trace SpeechRecognition's controller reference. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/speech/SpeechSynthesisUtterance.cpp

diff --git a/Source/modules/speech/SpeechSynthesisUtterance.cpp b/Source/modules/speech/SpeechSynthesisUtterance.cpp

index 2d98c03aec919979601b32fbc9bcc91a17941366..144342edf72aae9c83d17627057eb33d7fe555e7 100644

--- a/Source/modules/speech/SpeechSynthesisUtterance.cpp

+++ b/Source/modules/speech/SpeechSynthesisUtterance.cpp

@@ -43,7 +43,6 @@ SpeechSynthesisUtterance::SpeechSynthesisUtterance(ExecutionContext* context, co

SpeechSynthesisUtterance::~SpeechSynthesisUtterance()

{

- m_platformUtterance->setClient(0);

}

ExecutionContext* SpeechSynthesisUtterance::executionContext() const

@@ -73,6 +72,7 @@ void SpeechSynthesisUtterance::setVoice(SpeechSynthesisVoice* voice)

void SpeechSynthesisUtterance::trace(Visitor* visitor)

{

+ visitor->trace(m_platformUtterance);

visitor->trace(m_voice);

EventTargetWithInlineData::trace(visitor);

}