Oilpan: move platform speech objects to the heap.

Source/modules/speech/SpeechSynthesis.h

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 16 matching lines @@
 #define SpeechSynthesis_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "core/dom/ContextLifecycleObserver.h"
 #include "modules/EventTargetModules.h"
 #include "modules/speech/SpeechSynthesisUtterance.h"
 #include "modules/speech/SpeechSynthesisVoice.h"
 #include "platform/heap/Handle.h"
 #include "platform/speech/PlatformSpeechSynthesisUtterance.h"
 #include "platform/speech/PlatformSpeechSynthesizer.h"
-#include "wtf/PassRefPtr.h"
 
 namespace WebCore {
 
 class ExceptionState;
 class PlatformSpeechSynthesizerClient;
 
 class SpeechSynthesis FINAL : public RefCountedGarbageCollectedWillBeGarbageCollectedFinalized<SpeechSynthesis>, public PlatformSpeechSynthesizerClient, public ScriptWrappable, public ContextLifecycleObserver, public EventTargetWithInlineData {
     DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(RefCountedGarbageCollected<SpeechSynthesis>);
-    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SpeechSynthesis);

[haraken, 2014/06/17 09:18:50]

I'm a bit confused with this. You didn't drop WILL_BE_ from SpeechRecognition,
but dropped WILL_BE_ from SpeechSynthesis. What's the difference?

[sof, 2014/06/17 09:26:08]

PlatformSpeechSynthesizerClient is on the heap always, hence needed.

SpeechRecognition is optionally a mixin due to EventTarget* being
WillBeGarbageCollectedMixin.

[haraken, 2014/06/17 09:30:23]

Makes sense. If either of mixins is on the heap always, we need to drop the
WILL_BE_. Otherwise, we can leave the WILL_BE_ as is (it's also OK to drop it).

+    USING_GARBAGE_COLLECTED_MIXIN(SpeechSynthesis);
 public:
     static SpeechSynthesis* create(ExecutionContext*);
 
     bool pending() const;
     bool speaking() const;
     bool paused() const;
 
     void speak(SpeechSynthesisUtterance*, ExceptionState&);
     void cancel();
     void pause();
     void resume();
 
     const HeapVector<Member<SpeechSynthesisVoice> >& getVoices();
 
     // Used in testing to use a mock platform synthesizer
-    void setPlatformSynthesizer(PassOwnPtr<PlatformSpeechSynthesizer>);
+    void setPlatformSynthesizer(PlatformSpeechSynthesizer*);
 
     DEFINE_ATTRIBUTE_EVENT_LISTENER(voiceschanged);
 
     virtual ExecutionContext* executionContext() const OVERRIDE;
 
     virtual void trace(Visitor*) OVERRIDE;
 
 private:
     explicit SpeechSynthesis(ExecutionContext*);
 
     // PlatformSpeechSynthesizerClient override methods.
     virtual void voicesDidChange() OVERRIDE;
-    virtual void didStartSpeaking(PassRefPtr<PlatformSpeechSynthesisUtterance>) OVERRIDE;
-    virtual void didPauseSpeaking(PassRefPtr<PlatformSpeechSynthesisUtterance>) OVERRIDE;
-    virtual void didResumeSpeaking(PassRefPtr<PlatformSpeechSynthesisUtterance>) OVERRIDE;
-    virtual void didFinishSpeaking(PassRefPtr<PlatformSpeechSynthesisUtterance>) OVERRIDE;
-    virtual void speakingErrorOccurred(PassRefPtr<PlatformSpeechSynthesisUtterance>) OVERRIDE;
-    virtual void boundaryEventOccurred(PassRefPtr<PlatformSpeechSynthesisUtterance>, SpeechBoundary, unsigned charIndex) OVERRIDE;
+    virtual void didStartSpeaking(PlatformSpeechSynthesisUtterance*) OVERRIDE;
+    virtual void didPauseSpeaking(PlatformSpeechSynthesisUtterance*) OVERRIDE;
+    virtual void didResumeSpeaking(PlatformSpeechSynthesisUtterance*) OVERRIDE;
+    virtual void didFinishSpeaking(PlatformSpeechSynthesisUtterance*) OVERRIDE;
+    virtual void speakingErrorOccurred(PlatformSpeechSynthesisUtterance*) OVERRIDE;
+    virtual void boundaryEventOccurred(PlatformSpeechSynthesisUtterance*, SpeechBoundary, unsigned charIndex) OVERRIDE;
 
     void startSpeakingImmediately();
     void handleSpeakingCompleted(SpeechSynthesisUtterance*, bool errorOccurred);
     void fireEvent(const AtomicString& type, SpeechSynthesisUtterance*, unsigned long charIndex, const String& name);
 
     // Returns the utterance at the front of the queue.
     SpeechSynthesisUtterance* currentSpeechUtterance() const;
 
-    OwnPtr<PlatformSpeechSynthesizer> m_platformSpeechSynthesizer;
+    Member<PlatformSpeechSynthesizer> m_platformSpeechSynthesizer;
     HeapVector<Member<SpeechSynthesisVoice> > m_voiceList;
     HeapDeque<Member<SpeechSynthesisUtterance> > m_utteranceQueue;
     bool m_isPaused;
 
     // EventTarget
     virtual const AtomicString& interfaceName() const OVERRIDE;
 };
 
 } // namespace WebCore
 
 #endif // SpeechSynthesisEvent_h