Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: Source/modules/speech/SpeechSynthesisVoice.h

Issue 339823003: Oilpan: move platform speech objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Trace SpeechRecognition's controller reference. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/speech/SpeechSynthesisUtterance.cpp ('k') | Source/modules/speech/SpeechSynthesisVoice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/speech/SpeechSynthesisVoice.h
diff --git a/Source/modules/speech/SpeechSynthesisVoice.h b/Source/modules/speech/SpeechSynthesisVoice.h
index 81c82324dc90e7dde3baab0103b0a6a9b4e6747f..b3bdb20fc8e237acc862af87988a02aba7ed2486 100644
--- a/Source/modules/speech/SpeechSynthesisVoice.h
+++ b/Source/modules/speech/SpeechSynthesisVoice.h
@@ -29,15 +29,13 @@
#include "bindings/v8/ScriptWrappable.h"
#include "platform/heap/Handle.h"
#include "platform/speech/PlatformSpeechSynthesisVoice.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefCounted.h"
#include "wtf/text/WTFString.h"
namespace WebCore {
class SpeechSynthesisVoice FINAL : public GarbageCollectedFinalized<SpeechSynthesisVoice>, public ScriptWrappable {
public:
- static SpeechSynthesisVoice* create(PassRefPtr<PlatformSpeechSynthesisVoice>);
+ static SpeechSynthesisVoice* create(PlatformSpeechSynthesisVoice*);
const String& voiceURI() const { return m_platformVoice->voiceURI(); }
const String& name() const { return m_platformVoice->name(); }
@@ -45,14 +43,14 @@ public:
bool localService() const { return m_platformVoice->localService(); }
bool isDefault() const { return m_platformVoice->isDefault(); }
- PlatformSpeechSynthesisVoice* platformVoice() const { return m_platformVoice.get(); }
+ PlatformSpeechSynthesisVoice* platformVoice() const { return m_platformVoice; }
- void trace(Visitor*) { }
+ void trace(Visitor*);
private:
- explicit SpeechSynthesisVoice(PassRefPtr<PlatformSpeechSynthesisVoice>);
+ explicit SpeechSynthesisVoice(PlatformSpeechSynthesisVoice*);
- RefPtr<PlatformSpeechSynthesisVoice> m_platformVoice;
+ Member<PlatformSpeechSynthesisVoice> m_platformVoice;
};
} // namespace WebCore
« no previous file with comments | « Source/modules/speech/SpeechSynthesisUtterance.cpp ('k') | Source/modules/speech/SpeechSynthesisVoice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698