Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: Source/platform/speech/PlatformSpeechSynthesisVoice.h

Issue 339823003: Oilpan: move platform speech objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Trace SpeechRecognition's controller reference. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/speech/PlatformSpeechSynthesisVoice.h
diff --git a/Source/platform/speech/PlatformSpeechSynthesisVoice.h b/Source/platform/speech/PlatformSpeechSynthesisVoice.h
index 75b3043470a10a5964c973c168fb466890027a74..0a03543f35e414b5708e7c2504b6bbcf710be23c 100644
--- a/Source/platform/speech/PlatformSpeechSynthesisVoice.h
+++ b/Source/platform/speech/PlatformSpeechSynthesisVoice.h
@@ -27,16 +27,15 @@
#define PlatformSpeechSynthesisVoice_h
#include "platform/PlatformExport.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefCounted.h"
+#include "platform/heap/Handle.h"
#include "wtf/text/WTFString.h"
namespace WebCore {
-class PLATFORM_EXPORT PlatformSpeechSynthesisVoice : public RefCounted<PlatformSpeechSynthesisVoice> {
+class PLATFORM_EXPORT PlatformSpeechSynthesisVoice FINAL : public GarbageCollectedFinalized<PlatformSpeechSynthesisVoice> {
public:
- static PassRefPtr<PlatformSpeechSynthesisVoice> create(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault);
- static PassRefPtr<PlatformSpeechSynthesisVoice> create();
+ static PlatformSpeechSynthesisVoice* create(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault);
+ static PlatformSpeechSynthesisVoice* create();
const String& voiceURI() const { return m_voiceURI; }
void setVoiceURI(const String& voiceURI) { m_voiceURI = voiceURI; }
@@ -53,6 +52,8 @@ public:
bool isDefault() const { return m_default; }
void setIsDefault(bool isDefault) { m_default = isDefault; }
+ void trace(Visitor*) { }
+
private:
PlatformSpeechSynthesisVoice(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault);
PlatformSpeechSynthesisVoice();
« no previous file with comments | « Source/platform/speech/PlatformSpeechSynthesisUtterance.cpp ('k') | Source/platform/speech/PlatformSpeechSynthesisVoice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698