Oilpan: move page's ValidationMessageClient to the heap.

Oilpan: move page's ValidationMessageClient to the heap.

Avoids keeping a bare pointer to the current anchor from the client
implementation object.

R=ager@chromium.org,zerny@chromium.org,haraken@chromium.org,tkent@chromium.org
BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176206

[sof, 2014-06-16 09:41:24]

Please take a look.

(Pls ignore the trybot red for now -- compilation is busted after r176183.
Separately cleaning up.)

[Mads Ager (chromium), 2014-06-16 09:51:04]

LGTM

[haraken, 2014-06-16 10:17:42]

LGTM

[zerny-chromium, 2014-06-16 10:25:29]

lgtm

[sof, 2014-06-16 11:28:28]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-06-16 11:29:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/334153003/20001

[sof, 2014-06-16 11:51:06]

Changes Source/web/ code - tkent, please take a look?

[commit-bot: I haz the power, 2014-06-16 12:35:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 12:35:07]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7704)

[tkent, 2014-06-16 12:48:38]

lgtm

https://codereview.chromium.org/334153003/diff/20001/Source/core/page/Validat...
File Source/core/page/ValidationMessageClient.h (right):

https://codereview.chromium.org/334153003/diff/20001/Source/core/page/Validat...
Source/core/page/ValidationMessageClient.h:38: public:
nit: ValidationMessageClient can inherit from GarbageCollectedFinalized.

[sof, 2014-06-16 13:01:26]

https://codereview.chromium.org/334153003/diff/20001/Source/core/page/Validat...
File Source/core/page/ValidationMessageClient.h (right):

https://codereview.chromium.org/334153003/diff/20001/Source/core/page/Validat...
Source/core/page/ValidationMessageClient.h:38: public:
On 2014/06/16 12:48:38, tkent wrote:
> nit: ValidationMessageClient can inherit from GarbageCollectedFinalized.

It definitely could, but I considered that as mixing implementation with
interface.

[tkent, 2014-06-16 13:03:39]

https://codereview.chromium.org/334153003/diff/20001/Source/core/page/Validat...
File Source/core/page/ValidationMessageClient.h (right):

https://codereview.chromium.org/334153003/diff/20001/Source/core/page/Validat...
Source/core/page/ValidationMessageClient.h:38: public:
On 2014/06/16 13:01:26, sof wrote:
> On 2014/06/16 12:48:38, tkent wrote:
> > nit: ValidationMessageClient can inherit from GarbageCollectedFinalized.
> 
> It definitely could, but I considered that as mixing implementation with
> interface.

yeah, it's understandable.  You may land this as is.

[sof, 2014-06-16 13:05:01]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-06-16 13:05:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/334153003/20001

[sof, 2014-06-16 13:06:23]

On 2014/06/16 13:03:39, tkent wrote:
>
https://codereview.chromium.org/334153003/diff/20001/Source/core/page/Validat...
> File Source/core/page/ValidationMessageClient.h (right):
> 
>
https://codereview.chromium.org/334153003/diff/20001/Source/core/page/Validat...
> Source/core/page/ValidationMessageClient.h:38: public:
> On 2014/06/16 13:01:26, sof wrote:
> > On 2014/06/16 12:48:38, tkent wrote:
> > > nit: ValidationMessageClient can inherit from GarbageCollectedFinalized.
> > 
> > It definitely could, but I considered that as mixing implementation with
> > interface.
> 
> yeah, it's understandable.  You may land this as is.

Thanks. Relatedly, what should we do about ValidationMessage?

[commit-bot: I haz the power, 2014-06-16 13:09:37]

Change committed as 176206

[tkent, 2014-06-16 13:21:44]

On 2014/06/16 13:06:23, sof wrote:
> Thanks. Relatedly, what should we do about ValidationMessage?

We should remove ValidationMessage class by merging it into
HTMLFormControlElement class.