Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 334153003: Oilpan: move page's ValidationMessageClient to the heap. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: move page's ValidationMessageClient to the heap. Avoids keeping a bare pointer to the current anchor from the client implementation object. R=ager@chromium.org,zerny@chromium.org,haraken@chromium.org,tkent@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176206

Patch Set 1 #

Patch Set 2 : trace() mixing as per GC plugin requirements #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M Source/core/page/Page.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/ValidationMessageClient.h View 1 3 chunks +4 lines, -1 line 3 comments Download
M Source/web/ValidationMessageClientImpl.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M Source/web/ValidationMessageClientImpl.cpp View 1 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
sof
Please take a look. (Pls ignore the trybot red for now -- compilation is busted ...
6 years, 6 months ago (2014-06-16 09:41:24 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 6 months ago (2014-06-16 09:51:04 UTC) #2
haraken
LGTM
6 years, 6 months ago (2014-06-16 10:17:42 UTC) #3
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-16 10:25:29 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-16 11:28:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/334153003/20001
6 years, 6 months ago (2014-06-16 11:29:16 UTC) #6
sof
Changes Source/web/ code - tkent, please take a look?
6 years, 6 months ago (2014-06-16 11:51:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 12:35:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7704)
6 years, 6 months ago (2014-06-16 12:35:07 UTC) #9
tkent
lgtm https://codereview.chromium.org/334153003/diff/20001/Source/core/page/ValidationMessageClient.h File Source/core/page/ValidationMessageClient.h (right): https://codereview.chromium.org/334153003/diff/20001/Source/core/page/ValidationMessageClient.h#newcode38 Source/core/page/ValidationMessageClient.h:38: public: nit: ValidationMessageClient can inherit from GarbageCollectedFinalized.
6 years, 6 months ago (2014-06-16 12:48:38 UTC) #10
sof
https://codereview.chromium.org/334153003/diff/20001/Source/core/page/ValidationMessageClient.h File Source/core/page/ValidationMessageClient.h (right): https://codereview.chromium.org/334153003/diff/20001/Source/core/page/ValidationMessageClient.h#newcode38 Source/core/page/ValidationMessageClient.h:38: public: On 2014/06/16 12:48:38, tkent wrote: > nit: ValidationMessageClient ...
6 years, 6 months ago (2014-06-16 13:01:26 UTC) #11
tkent
https://codereview.chromium.org/334153003/diff/20001/Source/core/page/ValidationMessageClient.h File Source/core/page/ValidationMessageClient.h (right): https://codereview.chromium.org/334153003/diff/20001/Source/core/page/ValidationMessageClient.h#newcode38 Source/core/page/ValidationMessageClient.h:38: public: On 2014/06/16 13:01:26, sof wrote: > On 2014/06/16 ...
6 years, 6 months ago (2014-06-16 13:03:39 UTC) #12
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-16 13:05:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/334153003/20001
6 years, 6 months ago (2014-06-16 13:05:49 UTC) #14
sof
On 2014/06/16 13:03:39, tkent wrote: > https://codereview.chromium.org/334153003/diff/20001/Source/core/page/ValidationMessageClient.h > File Source/core/page/ValidationMessageClient.h (right): > > https://codereview.chromium.org/334153003/diff/20001/Source/core/page/ValidationMessageClient.h#newcode38 > ...
6 years, 6 months ago (2014-06-16 13:06:23 UTC) #15
commit-bot: I haz the power
Change committed as 176206
6 years, 6 months ago (2014-06-16 13:09:37 UTC) #16
tkent
6 years, 6 months ago (2014-06-16 13:21:44 UTC) #17
Message was sent while issue was closed.
On 2014/06/16 13:06:23, sof wrote:
> Thanks. Relatedly, what should we do about ValidationMessage?

We should remove ValidationMessage class by merging it into
HTMLFormControlElement class.

Powered by Google App Engine
This is Rietveld 408576698