Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: Source/web/ValidationMessageClientImpl.h

Issue 334153003: Oilpan: move page's ValidationMessageClient to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: trace() mixing as per GC plugin requirements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ValidationMessageClientImpl.h
diff --git a/Source/web/ValidationMessageClientImpl.h b/Source/web/ValidationMessageClientImpl.h
index f1fc29788bbcb30258e4cd80a8e7d89e2b7f2cb9..83967859d841351c0ea4c9d35dcba47431c23706 100644
--- a/Source/web/ValidationMessageClientImpl.h
+++ b/Source/web/ValidationMessageClientImpl.h
@@ -29,6 +29,7 @@
#include "core/page/ValidationMessageClient.h"
#include "platform/Timer.h"
#include "platform/geometry/IntRect.h"
+#include "platform/heap/Handle.h"
#include "wtf/text/WTFString.h"
namespace WebCore {
@@ -39,11 +40,14 @@ namespace blink {
class WebViewImpl;
-class ValidationMessageClientImpl FINAL : public WebCore::ValidationMessageClient {
+class ValidationMessageClientImpl FINAL : public NoBaseWillBeGarbageCollectedFinalized<ValidationMessageClientImpl>, public WebCore::ValidationMessageClient {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ValidationMessageClientImpl);
public:
- static PassOwnPtr<ValidationMessageClientImpl> create(WebViewImpl&);
+ static PassOwnPtrWillBeRawPtr<ValidationMessageClientImpl> create(WebViewImpl&);
virtual ~ValidationMessageClientImpl();
+ virtual void trace(WebCore::Visitor*) OVERRIDE;
+
private:
ValidationMessageClientImpl(WebViewImpl&);
void checkAnchorStatus(WebCore::Timer<ValidationMessageClientImpl>*);
@@ -56,7 +60,7 @@ private:
virtual void willBeDestroyed() OVERRIDE;
WebViewImpl& m_webView;
- const WebCore::Element* m_currentAnchor;
+ RawPtrWillBeMember<const WebCore::Element> m_currentAnchor;
String m_message;
WebCore::IntRect m_lastAnchorRectInScreen;
float m_lastPageScaleFactor;

Powered by Google App Engine
This is Rietveld 408576698