Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: Source/core/page/Page.h

Issue 334153003: Oilpan: move page's ValidationMessageClient to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: trace() mixing as per GC plugin requirements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/page/Page.cpp » ('j') | Source/core/page/ValidationMessageClient.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 PageAnimator& animator() { return m_animator; } 149 PageAnimator& animator() { return m_animator; }
150 Chrome& chrome() const { return *m_chrome; } 150 Chrome& chrome() const { return *m_chrome; }
151 AutoscrollController& autoscrollController() const { return *m_autoscrollCon troller; } 151 AutoscrollController& autoscrollController() const { return *m_autoscrollCon troller; }
152 DragCaretController& dragCaretController() const { return *m_dragCaretContro ller; } 152 DragCaretController& dragCaretController() const { return *m_dragCaretContro ller; }
153 DragController& dragController() const { return *m_dragController; } 153 DragController& dragController() const { return *m_dragController; }
154 FocusController& focusController() const { return *m_focusController; } 154 FocusController& focusController() const { return *m_focusController; }
155 ContextMenuController& contextMenuController() const { return *m_contextMenu Controller; } 155 ContextMenuController& contextMenuController() const { return *m_contextMenu Controller; }
156 InspectorController& inspectorController() const { return *m_inspectorContro ller; } 156 InspectorController& inspectorController() const { return *m_inspectorContro ller; }
157 PointerLockController& pointerLockController() const { return *m_pointerLock Controller; } 157 PointerLockController& pointerLockController() const { return *m_pointerLock Controller; }
158 ValidationMessageClient& validationMessageClient() const { return *m_validat ionMessageClient; } 158 ValidationMessageClient& validationMessageClient() const { return *m_validat ionMessageClient; }
159 void setValidationMessageClient(PassOwnPtr<ValidationMessageClient>); 159 void setValidationMessageClient(PassOwnPtrWillBeRawPtr<ValidationMessageClie nt>);
160 160
161 ScrollingCoordinator* scrollingCoordinator(); 161 ScrollingCoordinator* scrollingCoordinator();
162 162
163 String mainThreadScrollingReasonsAsText(); 163 String mainThreadScrollingReasonsAsText();
164 PassRefPtrWillBeRawPtr<ClientRectList> nonFastScrollableRects(const LocalFra me*); 164 PassRefPtrWillBeRawPtr<ClientRectList> nonFastScrollableRects(const LocalFra me*);
165 165
166 Settings& settings() const { return *m_settings; } 166 Settings& settings() const { return *m_settings; }
167 BackForwardClient& backForward() const { return *m_backForwardClient; } 167 BackForwardClient& backForward() const { return *m_backForwardClient; }
168 168
169 UseCounter& useCounter() { return m_useCounter; } 169 UseCounter& useCounter() { return m_useCounter; }
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 const OwnPtr<UndoStack> m_undoStack; 260 const OwnPtr<UndoStack> m_undoStack;
261 261
262 RefPtr<Frame> m_mainFrame; 262 RefPtr<Frame> m_mainFrame;
263 263
264 mutable RefPtr<PluginData> m_pluginData; 264 mutable RefPtr<PluginData> m_pluginData;
265 265
266 BackForwardClient* m_backForwardClient; 266 BackForwardClient* m_backForwardClient;
267 EditorClient* const m_editorClient; 267 EditorClient* const m_editorClient;
268 SpellCheckerClient* const m_spellCheckerClient; 268 SpellCheckerClient* const m_spellCheckerClient;
269 StorageClient* m_storageClient; 269 StorageClient* m_storageClient;
270 OwnPtr<ValidationMessageClient> m_validationMessageClient; 270 OwnPtrWillBeMember<ValidationMessageClient> m_validationMessageClient;
271 271
272 UseCounter m_useCounter; 272 UseCounter m_useCounter;
273 273
274 int m_subframeCount; 274 int m_subframeCount;
275 bool m_openedByDOM; 275 bool m_openedByDOM;
276 276
277 bool m_tabKeyCyclesThroughElements; 277 bool m_tabKeyCyclesThroughElements;
278 bool m_defersLoading; 278 bool m_defersLoading;
279 279
280 float m_deviceScaleFactor; 280 float m_deviceScaleFactor;
(...skipping 13 matching lines...) Expand all
294 WillBeHeapHashSet<RawPtrWillBeWeakMember<MultisamplingChangedObserver> > m_m ultisamplingChangedObservers; 294 WillBeHeapHashSet<RawPtrWillBeWeakMember<MultisamplingChangedObserver> > m_m ultisamplingChangedObservers;
295 295
296 // A pointer to all the interfaces provided to in-process Frames for this Pa ge. 296 // A pointer to all the interfaces provided to in-process Frames for this Pa ge.
297 // FIXME: Most of the members of Page should move onto FrameHost. 297 // FIXME: Most of the members of Page should move onto FrameHost.
298 OwnPtrWillBeMember<FrameHost> m_frameHost; 298 OwnPtrWillBeMember<FrameHost> m_frameHost;
299 }; 299 };
300 300
301 } // namespace WebCore 301 } // namespace WebCore
302 302
303 #endif // Page_h 303 #endif // Page_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/page/Page.cpp » ('j') | Source/core/page/ValidationMessageClient.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698