Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Unified Diff: Source/web/ValidationMessageClientImpl.cpp

Issue 334153003: Oilpan: move page's ValidationMessageClient to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: trace() mixing as per GC plugin requirements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ValidationMessageClientImpl.cpp
diff --git a/Source/web/ValidationMessageClientImpl.cpp b/Source/web/ValidationMessageClientImpl.cpp
index b40bf12ddde1536d660e6bc88c165d20ab40f7d3..54b7bda41d4839454acc377d4744d96858d83dc5 100644
--- a/Source/web/ValidationMessageClientImpl.cpp
+++ b/Source/web/ValidationMessageClientImpl.cpp
@@ -43,16 +43,16 @@ namespace blink {
ValidationMessageClientImpl::ValidationMessageClientImpl(WebViewImpl& webView)
: m_webView(webView)
- , m_currentAnchor(0)
+ , m_currentAnchor(nullptr)
, m_lastPageScaleFactor(1)
, m_finishTime(0)
, m_timer(this, &ValidationMessageClientImpl::checkAnchorStatus)
{
}
-PassOwnPtr<ValidationMessageClientImpl> ValidationMessageClientImpl::create(WebViewImpl& webView)
+PassOwnPtrWillBeRawPtr<ValidationMessageClientImpl> ValidationMessageClientImpl::create(WebViewImpl& webView)
{
- return adoptPtr(new ValidationMessageClientImpl(webView));
+ return adoptPtrWillBeNoop(new ValidationMessageClientImpl(webView));
}
ValidationMessageClientImpl::~ValidationMessageClientImpl()
@@ -98,7 +98,7 @@ void ValidationMessageClientImpl::hideValidationMessage(const Element& anchor)
if (!m_currentAnchor || !isValidationMessageVisible(anchor))
return;
m_timer.stop();
- m_currentAnchor = 0;
+ m_currentAnchor = nullptr;
m_message = String();
m_finishTime = 0;
m_webView.client()->hideValidationMessage();
@@ -146,4 +146,10 @@ void ValidationMessageClientImpl::willBeDestroyed()
hideValidationMessage(*m_currentAnchor);
}
+void ValidationMessageClientImpl::trace(Visitor* visitor)
+{
+ visitor->trace(m_currentAnchor);
+ ValidationMessageClient::trace(visitor);
+}
+
}
« Source/core/page/ValidationMessageClient.h ('K') | « Source/web/ValidationMessageClientImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698