Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/core/page/Page.cpp

Issue 334153003: Oilpan: move page's ValidationMessageClient to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: trace() mixing as per GC plugin requirements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 return; 305 return;
306 306
307 Frame* frame = mainFrame(); 307 Frame* frame = mainFrame();
308 do { 308 do {
309 if (frame->isLocalFrame()) 309 if (frame->isLocalFrame())
310 toLocalFrame(frame)->document()->markers().removeMarkers(DocumentMar ker::TextMatch); 310 toLocalFrame(frame)->document()->markers().removeMarkers(DocumentMar ker::TextMatch);
311 frame = incrementFrame(frame, true, false); 311 frame = incrementFrame(frame, true, false);
312 } while (frame); 312 } while (frame);
313 } 313 }
314 314
315 void Page::setValidationMessageClient(PassOwnPtr<ValidationMessageClient> client ) 315 void Page::setValidationMessageClient(PassOwnPtrWillBeRawPtr<ValidationMessageCl ient> client)
316 { 316 {
317 m_validationMessageClient = client; 317 m_validationMessageClient = client;
318 } 318 }
319 319
320 void Page::setDefersLoading(bool defers) 320 void Page::setDefersLoading(bool defers)
321 { 321 {
322 if (defers == m_defersLoading) 322 if (defers == m_defersLoading)
323 return; 323 return;
324 324
325 m_defersLoading = defers; 325 m_defersLoading = defers;
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 PassOwnPtr<LifecycleNotifier<Page> > Page::createLifecycleNotifier() 587 PassOwnPtr<LifecycleNotifier<Page> > Page::createLifecycleNotifier()
588 { 588 {
589 return PageLifecycleNotifier::create(this); 589 return PageLifecycleNotifier::create(this);
590 } 590 }
591 591
592 void Page::trace(Visitor* visitor) 592 void Page::trace(Visitor* visitor)
593 { 593 {
594 visitor->trace(m_dragCaretController); 594 visitor->trace(m_dragCaretController);
595 visitor->trace(m_dragController); 595 visitor->trace(m_dragController);
596 visitor->trace(m_pointerLockController); 596 visitor->trace(m_pointerLockController);
597 visitor->trace(m_validationMessageClient);
597 visitor->trace(m_multisamplingChangedObservers); 598 visitor->trace(m_multisamplingChangedObservers);
598 visitor->trace(m_frameHost); 599 visitor->trace(m_frameHost);
599 WillBeHeapSupplementable<Page>::trace(visitor); 600 WillBeHeapSupplementable<Page>::trace(visitor);
600 } 601 }
601 602
602 void Page::willBeDestroyed() 603 void Page::willBeDestroyed()
603 { 604 {
604 if (m_mainFrame && m_mainFrame->isLocalFrame()) 605 if (m_mainFrame && m_mainFrame->isLocalFrame())
605 deprecatedLocalMainFrame()->loader().frameDetached(); 606 deprecatedLocalMainFrame()->loader().frameDetached();
606 607
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
642 , spellCheckerClient(0) 643 , spellCheckerClient(0)
643 , storageClient(0) 644 , storageClient(0)
644 { 645 {
645 } 646 }
646 647
647 Page::PageClients::~PageClients() 648 Page::PageClients::~PageClients()
648 { 649 {
649 } 650 }
650 651
651 } // namespace WebCore 652 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698