Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 330593004: Use scratch with LATC data if possible (Closed)

Created:
6 years, 6 months ago by krajcevski
Modified:
6 years, 6 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -36 lines) Patch
M src/gpu/GrSWMaskHelper.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 3 chunks +39 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
krajcevski
6 years, 6 months ago (2014-06-12 13:29:09 UTC) #1
robertphillips
https://codereview.chromium.org/330593004/diff/1/src/gpu/GrSWMaskHelper.cpp File src/gpu/GrSWMaskHelper.cpp (right): https://codereview.chromium.org/330593004/diff/1/src/gpu/GrSWMaskHelper.cpp#newcode129 src/gpu/GrSWMaskHelper.cpp:129: static const int kLATCBlockSize = 4; 1 line for ...
6 years, 6 months ago (2014-06-12 14:43:33 UTC) #2
krajcevski
https://codereview.chromium.org/330593004/diff/1/src/gpu/GrSWMaskHelper.cpp File src/gpu/GrSWMaskHelper.cpp (right): https://codereview.chromium.org/330593004/diff/1/src/gpu/GrSWMaskHelper.cpp#newcode129 src/gpu/GrSWMaskHelper.cpp:129: static const int kLATCBlockSize = 4; On 2014/06/12 14:43:33, ...
6 years, 6 months ago (2014-06-12 15:13:33 UTC) #3
robertphillips
lgtm
6 years, 6 months ago (2014-06-12 15:26:54 UTC) #4
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 6 months ago (2014-06-12 15:43:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/330593004/20001
6 years, 6 months ago (2014-06-12 15:43:53 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:20:43 UTC) #7
Message was sent while issue was closed.
Change committed as fb4f5cb39e31b8544b526074683a65bb716b7acf

Powered by Google App Engine
This is Rietveld 408576698