Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of

Cleanup: Make ExtensionService:: and ExtensionPrefs::OnExtensionInstalled
take a bitmask instead of 4 boolean values (soon to be 5).

As part of that, change the default-true flag "wait for idle" to a
default-false flag "install immediately".

R=asargent@chromium.org
TBR=estade@chromium.org, atwilson@chromium.org, dimich@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276999

[not at google - send to devlin, 2014-06-09 23:34:24]

Not as scary as it looks, and certainly more of a pain to write than review...

[xiyuan, 2014-06-10 17:07:28]

https://codereview.chromium.org/322893002/diff/60001/extensions/browser/exten...
File extensions/browser/extension_prefs.h (right):

https://codereview.chromium.org/322893002/diff/60001/extensions/browser/exten...
extensions/browser/extension_prefs.h:201: extension, initial_state,
page_ordinal, install_parameter);
Seems missing the default install flags to call the 5-args version of
OnExtensionInstalled.

[not at google - send to devlin, 2014-06-10 17:08:42]

https://codereview.chromium.org/322893002/diff/60001/extensions/browser/exten...
File extensions/browser/extension_prefs.h (right):

https://codereview.chromium.org/322893002/diff/60001/extensions/browser/exten...
extensions/browser/extension_prefs.h:201: extension, initial_state,
page_ordinal, install_parameter);
On 2014/06/10 17:07:28, xiyuan wrote:
> Seems missing the default install flags to call the 5-args version of
> OnExtensionInstalled.

yes, this is ... a terrifying infinite loop. thank you :)

[asargent_no_longer_on_chrome, 2014-06-10 17:50:08]

lgtm

[not at google - send to devlin, 2014-06-10 22:59:06]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-06-10 23:00:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/322893002/70001

[commit-bot: I haz the power, 2014-06-11 04:48:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18336)

[commit-bot: I haz the power, 2014-06-11 04:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 04:55:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[not at google - send to devlin, 2014-06-11 14:51:09]

The CQ bit was checked by kalman@chromium.org

[not at google - send to devlin, 2014-06-11 14:51:22]

The CQ bit was unchecked by kalman@chromium.org

[not at google - send to devlin, 2014-06-11 14:54:57]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-06-11 14:57:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/322893002/90001

[commit-bot: I haz the power, 2014-06-11 20:26:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18629)

[commit-bot: I haz the power, 2014-06-11 20:52:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 20:52:33]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18750)

[not at google - send to devlin, 2014-06-12 04:09:35]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-06-12 04:16:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/322893002/110001

[commit-bot: I haz the power, 2014-06-12 10:18:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/19063)

[commit-bot: I haz the power, 2014-06-12 10:25:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 10:25:37]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[not at google - send to devlin, 2014-06-12 15:43:07]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-06-12 15:45:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/322893002/130001

[commit-bot: I haz the power, 2014-06-12 20:05:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/19344)

[commit-bot: I haz the power, 2014-06-12 21:27:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 21:27:27]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/19447)

[not at google - send to devlin, 2014-06-13 02:43:11]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-06-13 02:45:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/322893002/150001

[commit-bot: I haz the power, 2014-06-13 08:28:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-13 12:50:16]

Change committed as 276999