Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/browser/extensions/chrome_app_sorting_unittest.cc

Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more win compile fixes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/chrome_app_sorting_unittest.cc
diff --git a/chrome/browser/extensions/chrome_app_sorting_unittest.cc b/chrome/browser/extensions/chrome_app_sorting_unittest.cc
index 7e9f4ea89617faeea39e787697b0bb29ecf55dbb..a97710ccdcada777d71b65e9e96ef90fa643e68b 100644
--- a/chrome/browser/extensions/chrome_app_sorting_unittest.cc
+++ b/chrome/browser/extensions/chrome_app_sorting_unittest.cc
@@ -30,8 +30,6 @@ class ChromeAppSortingAppLocation : public ChromeAppSortingTest {
// Non-apps should not have any app launch ordinal or page ordinal.
prefs()->OnExtensionInstalled(extension_.get(),
Extension::ENABLED,
- false,
- false,
syncer::StringOrdinal(),
std::string());
}
@@ -60,8 +58,6 @@ class ChromeAppSortingAppLaunchOrdinal : public ChromeAppSortingTest {
EXPECT_FALSE(prefs()->IsExtensionDisabled(extension_->id()));
prefs()->OnExtensionInstalled(extension_.get(),
Extension::ENABLED,
- false,
- false,
syncer::StringOrdinal(),
std::string());
}
@@ -114,8 +110,6 @@ class ChromeAppSortingPageOrdinal : public ChromeAppSortingTest {
first_page_ = syncer::StringOrdinal::CreateInitialOrdinal();
prefs()->OnExtensionInstalled(extension_.get(),
Extension::ENABLED,
- false,
- false,
first_page_,
std::string());
EXPECT_TRUE(first_page_.Equals(
@@ -126,8 +120,6 @@ class ChromeAppSortingPageOrdinal : public ChromeAppSortingTest {
// Install without any page preference.
prefs()->OnExtensionInstalled(extension2.get(),
Extension::ENABLED,
- false,
- false,
syncer::StringOrdinal(),
std::string());
EXPECT_TRUE(first_page_.Equals(
@@ -643,8 +635,6 @@ class ChromeAppSortingPreinstalledAppsBase : public PrefsPrepopulatedTestBase {
simple_dict, Extension::NO_FLAGS, &error);
prefs()->OnExtensionInstalled(app1_scoped_.get(),
Extension::ENABLED,
- false,
- false,
syncer::StringOrdinal(),
std::string());
@@ -653,8 +643,6 @@ class ChromeAppSortingPreinstalledAppsBase : public PrefsPrepopulatedTestBase {
simple_dict, Extension::NO_FLAGS, &error);
prefs()->OnExtensionInstalled(app2_scoped_.get(),
Extension::ENABLED,
- false,
- false,
syncer::StringOrdinal(),
std::string());
@@ -841,8 +829,6 @@ class ChromeAppSortingDefaultOrdinalsBase : public ChromeAppSortingTest {
virtual void InstallApps() {
prefs()->OnExtensionInstalled(app_.get(),
Extension::ENABLED,
- false,
- false,
syncer::StringOrdinal(),
std::string());
}
@@ -890,8 +876,6 @@ class ChromeAppSortingDefaultOrdinalOverriddenByInstallPage
install_page_ = default_page_ordinal_.CreateAfter();
prefs()->OnExtensionInstalled(app_.get(),
Extension::ENABLED,
- false,
- false,
install_page_,
std::string());
}
« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698