chrome/browser/extensions/app_process_apitest.cc - Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_process_apitest.cc

Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more win compile fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc ('k') | chrome/browser/extensions/chrome_app_sorting_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/app_process_apitest.cc

diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc

index 9eb11f6f5bb78b6af2b82f49816b03061f87a06b..a5c7f3173a9851f9fe43dacec36c5836e7482b52 100644

--- a/chrome/browser/extensions/app_process_apitest.cc

+++ b/chrome/browser/extensions/app_process_apitest.cc

@@ -27,6 +27,7 @@

#include "content/public/test/test_navigation_observer.h"

#include "extensions/browser/extension_host.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/browser/install_flag.h"

#include "extensions/browser/process_map.h"

#include "extensions/common/extension.h"

#include "extensions/common/file_util.h"

@@ -310,10 +311,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_BookmarkAppGetsNormalProcess) {

&error));

service->OnExtensionInstalled(extension.get(),

syncer::StringOrdinal::CreateInitialOrdinal(),

- false /* no requirement errors */,

- extensions::NOT_BLACKLISTED,

- false /* not ephemeral */,

- false /* don't wait for idle */);

+ extensions::kInstallFlagInstallImmediately);

ASSERT_TRUE(extension.get());

ASSERT_TRUE(extension->from_bookmark());