Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of

chrome/browser/extensions/shared_module_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_service_test_base.h"
 #include "chrome/browser/extensions/pending_extension_manager.h"
 #include "chrome/browser/extensions/shared_module_service.h"
 #include "chrome/common/extensions/features/feature_channel.h"
 #include "extensions/browser/extension_registry.h"
+#include "extensions/browser/install_flag.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/id_util.h"
 #include "extensions/common/value_builder.h"
 #include "sync/api/string_ordinal.h"
 
 namespace extensions {
 
 namespace {
 
 // Return an extension with |id| which imports a module with the given
@@ skipping 40 matching lines @@
 testing::AssertionResult SharedModuleServiceUnitTest::InstallExtension(
     const Extension* extension) {
   // Verify the extension is not already installed.
   if (registry()->GetExtensionById(extension->id(),
                                    ExtensionRegistry::ENABLED)) {
     return testing::AssertionFailure() << "Extension already installed.";
   }
 
   // Notify the service that the extension is installed. This adds it to the
   // registry, notifies interested parties, etc.
-  service_->OnExtensionInstalled(extension,
-                                 syncer::StringOrdinal(),
-                                 false,  // No requirement errors.
-                                 NOT_BLACKLISTED,
-                                 false,  // Not ephemeral.
-                                 false);  // Don't wait for idle.
+  service_->OnExtensionInstalled(
+      extension, syncer::StringOrdinal(), kInstallFlagInstallImmediately);
 
   // Verify that the extension is now installed.
   if (!registry()->GetExtensionById(extension->id(),
                                     ExtensionRegistry::ENABLED)) {
     return testing::AssertionFailure() << "Could not install extension.";
   }
 
   return testing::AssertionSuccess();
 }
 
@@ skipping 82 matching lines @@
       CreateExtensionImportingModule(shared_module->id(), whitelisted_id);
   EXPECT_TRUE(InstallExtension(whitelisted_extension));
 
   // Try to install an extension with an ID that is not whitelisted.
   scoped_refptr<Extension> nonwhitelisted_extension =
       CreateExtensionImportingModule(shared_module->id(), nonwhitelisted_id);
   EXPECT_FALSE(InstallExtension(nonwhitelisted_extension));
 }
 
 }  // namespace extensions