chrome/browser/extensions/extension_prefs_unittest.cc - Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 322893002: Cleanup: Make ExtensionService::OnExtensionInstalled take a bitmask instead of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more win compile fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_prefs_unittest.cc

diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc

index 965e1e19550ff698c0ff147fdb56242a7b78b225..2ed70d6a96fca27923ff3c7f6030b32dbc68c1e8 100644

--- a/chrome/browser/extensions/extension_prefs_unittest.cc

+++ b/chrome/browser/extensions/extension_prefs_unittest.cc

@@ -22,6 +22,7 @@

#include "content/public/test/mock_notification_observer.h"

#include "extensions/browser/extension_pref_value_map.h"

#include "extensions/browser/extension_prefs.h"

+#include "extensions/browser/install_flag.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest_constants.h"

#include "extensions/common/permissions/permission_set.h"

@@ -484,8 +485,7 @@ class ExtensionPrefsDelayedInstallInfo : public ExtensionPrefsTest {

ASSERT_EQ(id, extension->id());

prefs()->SetDelayedInstallInfo(extension.get(),

Extension::ENABLED,

- false,

+ kInstallFlagNone,

ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE,

syncer::StringOrdinal(),

std::string());

@@ -610,8 +610,7 @@ class ExtensionPrefsFinishDelayedInstallInfo : public ExtensionPrefsTest {

ASSERT_EQ(id_, new_extension->id());

prefs()->SetDelayedInstallInfo(new_extension.get(),

Extension::ENABLED,

- false,

+ kInstallFlagNone,

ExtensionPrefs::DELAY_REASON_WAIT_FOR_IDLE,

syncer::StringOrdinal(),

"Param");

@@ -650,8 +649,6 @@ class ExtensionPrefsOnExtensionInstalled : public ExtensionPrefsTest {

EXPECT_FALSE(prefs()->IsExtensionDisabled(extension_->id()));

prefs()->OnExtensionInstalled(extension_.get(),

Extension::DISABLED,

- false,

syncer::StringOrdinal(),

"Param");

}

@@ -674,8 +671,6 @@ class ExtensionPrefsAppDraggedByUser : public ExtensionPrefsTest {

EXPECT_FALSE(prefs()->WasAppDraggedByUser(extension_->id()));

prefs()->OnExtensionInstalled(extension_.get(),

Extension::ENABLED,

- false,

syncer::StringOrdinal(),

std::string());

}