Refactored the ShortcutLocations.hidden flag on linux

Refactored the ShortcutLocations.hidden flag on linux

Linux uses the web_app::ShortcutLocations.hidden flag to create hidden
shortcuts. This patch changes this flag into enum value
APP_MENU_LOCATION_HIDDEN in order to simplify shortcut creation code.

BUG=None
TEST=unit_tests (ShellIntegrationTest.*)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276297

[tmdiep, 2014-06-06 08:34:14]

I refactored the hidden flag to make the shortcut creation code easier to
follow. Please see:
https://codereview.chromium.org/311293002/#msg7

If this is ok, I'll commit this patch, rebase the one above, and use
APP_MENU_LOCATION_HIDDEN instead of the hidden flag.

https://codereview.chromium.org/320503004/diff/1/chrome/browser/web_applicati...
File chrome/browser/web_applications/web_app_linux.cc (left):

https://codereview.chromium.org/320503004/diff/1/chrome/browser/web_applicati...
chrome/browser/web_applications/web_app_linux.cc:60: creation_locations.hidden =
true;
Note: This creates shortcuts even if one did not previously exist. When apps
(hosted, v1, v2) get updated, this code will run - initiated in
AppShortcutManager. If they were hidden (assuming NoDisplay=true in the .desktop
files actually worked) it's not a big deal.

[Matt Giuca, 2014-06-10 01:00:47]

Great idea to simplify the data structure. Nice refactor. LGTM.

https://codereview.chromium.org/320503004/diff/1/chrome/browser/web_applicati...
File chrome/browser/web_applications/web_app.h (right):

https://codereview.chromium.org/320503004/diff/1/chrome/browser/web_applicati...
chrome/browser/web_applications/web_app.h:64: // app with the OS (in order to
give their windows dock icons, and correct icons
nit: Give *its* windows dock icons (s/their/its).
nit: Shelf, not dock (dock is Mac-specific terminology, shelf is what we use for
the generic word across platforms, for example see AppListPositioner).

[Matt Giuca, 2014-06-10 01:01:19]

+erg for OWNERS on shell_integration_linux.

[benwells, 2014-06-10 01:32:42]

On 2014/06/10 01:01:19, Matt Giuca wrote:
> +erg for OWNERS on shell_integration_linux.

stamp lgtm

[Elliot Glaysher, 2014-06-10 18:04:50]

lgtm owners stamp

[tmdiep, 2014-06-10 22:12:15]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-06-10 22:15:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tmdiep@chromium.org/320503004/20001

[commit-bot: I haz the power, 2014-06-11 07:38:31]

Change committed as 276297