Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: chrome/browser/shell_integration_linux_unittest.cc

Issue 320503004: Refactored the ShortcutLocations.hidden flag on linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration_linux.cc ('k') | chrome/browser/web_applications/web_app.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/shell_integration_linux_unittest.cc
diff --git a/chrome/browser/shell_integration_linux_unittest.cc b/chrome/browser/shell_integration_linux_unittest.cc
index 2b379957a5da2003f6eb5209fa497fe8e17f41b4..6f3d1f6eb774d01499cf7ecea4d2d3a11f3dc2a6 100644
--- a/chrome/browser/shell_integration_linux_unittest.cc
+++ b/chrome/browser/shell_integration_linux_unittest.cc
@@ -175,7 +175,6 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
result.applications_menu_location);
EXPECT_FALSE(result.in_quick_launch_bar);
- EXPECT_FALSE(result.hidden);
}
// Shortcut on desktop.
@@ -196,7 +195,6 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
result.applications_menu_location);
EXPECT_FALSE(result.in_quick_launch_bar);
- EXPECT_FALSE(result.hidden);
}
// Shortcut in applications directory.
@@ -218,7 +216,6 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
result.applications_menu_location);
EXPECT_FALSE(result.in_quick_launch_bar);
- EXPECT_FALSE(result.hidden);
}
// Shortcut in applications directory with NoDisplay=true.
@@ -237,10 +234,9 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
GetExistingShortcutLocations(&env, kProfilePath, kExtensionId);
// Doesn't count as being in applications menu.
EXPECT_FALSE(result.on_desktop);
- EXPECT_EQ(web_app::APP_MENU_LOCATION_NONE,
+ EXPECT_EQ(web_app::APP_MENU_LOCATION_HIDDEN,
result.applications_menu_location);
EXPECT_FALSE(result.in_quick_launch_bar);
- EXPECT_TRUE(result.hidden);
}
// Shortcut on desktop and in applications directory.
@@ -269,7 +265,6 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
EXPECT_EQ(web_app::APP_MENU_LOCATION_SUBDIR_CHROMEAPPS,
result.applications_menu_location);
EXPECT_FALSE(result.in_quick_launch_bar);
- EXPECT_FALSE(result.hidden);
}
}
« no previous file with comments | « chrome/browser/shell_integration_linux.cc ('k') | chrome/browser/web_applications/web_app.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698