Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4919)

Unified Diff: chrome/browser/web_applications/web_app.h

Issue 320503004: Refactored the ShortcutLocations.hidden flag on linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration_linux_unittest.cc ('k') | chrome/browser/web_applications/web_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app.h
diff --git a/chrome/browser/web_applications/web_app.h b/chrome/browser/web_applications/web_app.h
index 29e730a017be5f5bcf83590397c4bb87bd4d319c..79487681b57dad686bae7d318065c8547e01bd58 100644
--- a/chrome/browser/web_applications/web_app.h
+++ b/chrome/browser/web_applications/web_app.h
@@ -60,6 +60,10 @@ struct ShortcutInfo {
// These represent the applications menu root, the "Google Chrome" folder and
// the "Chrome Apps" folder respectively.
//
+// APP_MENU_LOCATION_HIDDEN specifies a shortcut that is used to register the
+// app with the OS (in order to give its windows shelf icons, and correct icons
+// and titles), but the app should not show up in menus or search results.
+//
// NB: On Linux, these locations may not be used by the window manager (e.g
// Unity and Gnome Shell).
enum ApplicationsMenuLocation {
@@ -67,6 +71,7 @@ enum ApplicationsMenuLocation {
APP_MENU_LOCATION_ROOT,
APP_MENU_LOCATION_SUBDIR_CHROME,
APP_MENU_LOCATION_SUBDIR_CHROMEAPPS,
+ APP_MENU_LOCATION_HIDDEN,
};
// Info about which locations to create app shortcuts in.
@@ -82,14 +87,6 @@ struct ShortcutLocations {
// Mac dock or the gnome/kde application launcher. However, those are not
// implemented yet.
bool in_quick_launch_bar;
-
-#if defined(OS_POSIX)
- // For Linux, this refers to a shortcut which the system knows about (for
- // the purpose of identifying windows and giving them the correct
- // title/icon), but which does not show up in menus or search results.
- // Ignored if applications_menu_location is not APP_MENU_LOCATION_NONE.
- bool hidden;
-#endif
};
// This encodes the cause of shortcut creation as the correct behavior in each
« no previous file with comments | « chrome/browser/shell_integration_linux_unittest.cc ('k') | chrome/browser/web_applications/web_app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698