Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/browser/web_applications/web_app.cc

Issue 320503004: Refactored the ShortcutLocations.hidden flag on linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/web_applications/web_app.h" 5 #include "chrome/browser/web_applications/web_app.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/i18n/file_util_icu.h" 10 #include "base/i18n/file_util_icu.h"
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 230
231 ShortcutInfo::ShortcutInfo() 231 ShortcutInfo::ShortcutInfo()
232 : is_platform_app(false) { 232 : is_platform_app(false) {
233 } 233 }
234 234
235 ShortcutInfo::~ShortcutInfo() {} 235 ShortcutInfo::~ShortcutInfo() {}
236 236
237 ShortcutLocations::ShortcutLocations() 237 ShortcutLocations::ShortcutLocations()
238 : on_desktop(false), 238 : on_desktop(false),
239 applications_menu_location(APP_MENU_LOCATION_NONE), 239 applications_menu_location(APP_MENU_LOCATION_NONE),
240 in_quick_launch_bar(false) 240 in_quick_launch_bar(false) {
241 #if defined(OS_POSIX)
242 , hidden(false)
243 #endif
244 {
245 } 241 }
246 242
247 void GetShortcutInfoForTab(content::WebContents* web_contents, 243 void GetShortcutInfoForTab(content::WebContents* web_contents,
248 ShortcutInfo* info) { 244 ShortcutInfo* info) {
249 DCHECK(info); // Must provide a valid info. 245 DCHECK(info); // Must provide a valid info.
250 246
251 const FaviconTabHelper* favicon_tab_helper = 247 const FaviconTabHelper* favicon_tab_helper =
252 FaviconTabHelper::FromWebContents(web_contents); 248 FaviconTabHelper::FromWebContents(web_contents);
253 const extensions::TabHelper* extensions_tab_helper = 249 const extensions::TabHelper* extensions_tab_helper =
254 extensions::TabHelper::FromWebContents(web_contents); 250 extensions::TabHelper::FromWebContents(web_contents);
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 447
452 #if defined(OS_LINUX) 448 #if defined(OS_LINUX)
453 std::string GetWMClassFromAppName(std::string app_name) { 449 std::string GetWMClassFromAppName(std::string app_name) {
454 file_util::ReplaceIllegalCharactersInPath(&app_name, '_'); 450 file_util::ReplaceIllegalCharactersInPath(&app_name, '_');
455 base::TrimString(app_name, "_", &app_name); 451 base::TrimString(app_name, "_", &app_name);
456 return app_name; 452 return app_name;
457 } 453 }
458 #endif 454 #endif
459 455
460 } // namespace web_app 456 } // namespace web_app
OLDNEW
« no previous file with comments | « chrome/browser/web_applications/web_app.h ('k') | chrome/browser/web_applications/web_app_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698