Refactored the ShortcutLocations.hidden flag on linux

chrome/browser/web_applications/web_app.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_
 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 42 matching lines @@
   base::FilePath profile_path;
   std::string profile_name;
 };
 
 // This specifies a folder in the system applications menu (e.g the Start Menu
 // on Windows).
 //
 // These represent the applications menu root, the "Google Chrome" folder and
 // the "Chrome Apps" folder respectively.
 //
+// APP_MENU_LOCATION_HIDDEN specifies a shortcut that is used to register the
+// app with the OS (in order to give their windows dock icons, and correct icons

[Matt Giuca, 2014/06/10 01:00:47]

nit: Give *its* windows dock icons (s/their/its).
nit: Shelf, not dock (dock is Mac-specific terminology, shelf is what we use for
the generic word across platforms, for example see AppListPositioner).

+// and titles), but the app should not show up in menus or search results.
+//
 // NB: On Linux, these locations may not be used by the window manager (e.g
 // Unity and Gnome Shell).
 enum ApplicationsMenuLocation {
   APP_MENU_LOCATION_NONE,
   APP_MENU_LOCATION_ROOT,
   APP_MENU_LOCATION_SUBDIR_CHROME,
   APP_MENU_LOCATION_SUBDIR_CHROMEAPPS,
+  APP_MENU_LOCATION_HIDDEN,
 };
 
 // Info about which locations to create app shortcuts in.
 struct ShortcutLocations {
   ShortcutLocations();
 
   bool on_desktop;
 
   ApplicationsMenuLocation applications_menu_location;
 
   // For Windows, this refers to quick launch bar prior to Win7. In Win7,
   // this means "pin to taskbar". For Mac/Linux, this could be used for
   // Mac dock or the gnome/kde application launcher. However, those are not
   // implemented yet.
   bool in_quick_launch_bar;
-
-#if defined(OS_POSIX)
-  // For Linux, this refers to a shortcut which the system knows about (for
-  // the purpose of identifying windows and giving them the correct
-  // title/icon), but which does not show up in menus or search results.
-  // Ignored if applications_menu_location is not APP_MENU_LOCATION_NONE.
-  bool hidden;
-#endif
 };
 
 // This encodes the cause of shortcut creation as the correct behavior in each
 // case is implementation specific.
 enum ShortcutCreationReason {
   SHORTCUT_CREATION_BY_USER,
   SHORTCUT_CREATION_AUTOMATED,
 };
 
 typedef base::Callback<void(const ShortcutInfo&)> ShortcutInfoCallback;
@@ skipping 146 matching lines @@
 
 // Sanitizes |name| and returns a version of it that is safe to use as an
 // on-disk file name .
 base::FilePath GetSanitizedFileName(const base::string16& name);
 
 }  // namespace internals
 
 }  // namespace web_app
 
 #endif  // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_H_