Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 313973003: Rename ElementData's attribute related methods for clarity (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
esprehn, adamk
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org
Visibility:
Public.

Description

Rename ElementData's attribute related methods for clarity Rename ElementData's attribute related methods for clarity: * length() -> attributeCount() * isEmpty() -> hasAttributes() * getAttributeItem(name) -> findAttributeByName(name) * attributeItem(index) -> attributeAt(index) * getAttributeItemIndex(name) -> findAttributeIndexByName(name) * addAttribute(name, value) -> appendAttribute(name, value) * removeAttribute(index) -> removeAttributeAt(index) This is inpired by the following WebKit revision by benjamin@webkit.org: http://trac.webkit.org/changeset/162394 R=esprehn@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -93 lines) Patch
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/core/dom/Element.cpp View 22 chunks +32 lines, -32 lines 0 comments Download
M Source/core/dom/ElementData.h View 10 chunks +26 lines, -26 lines 0 comments Download
M Source/core/dom/ElementData.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/ElementDataCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Inactive
6 years, 6 months ago (2014-06-05 20:29:16 UTC) #1
esprehn
lgtm
6 years, 6 months ago (2014-06-05 20:45:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/313973003/1
6 years, 6 months ago (2014-06-05 20:46:08 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-05 20:48:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 20:51:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/11178)
6 years, 6 months ago (2014-06-05 20:51:13 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-05 20:53:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/313973003/1
6 years, 6 months ago (2014-06-05 20:54:11 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-05 20:56:43 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 20:58:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/11183)
6 years, 6 months ago (2014-06-05 20:58:37 UTC) #11
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-05 23:16:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/313973003/1
6 years, 6 months ago (2014-06-05 23:16:21 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-06 00:29:22 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 00:55:52 UTC) #15
Message was sent while issue was closed.
Change committed as 175611

Powered by Google App Engine
This is Rietveld 408576698