Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 313973003: Rename ElementData's attribute related methods for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/NamedNodeMap.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 AtomicString valueString = fastGetAttribute(valueAttr); 445 AtomicString valueString = fastGetAttribute(valueAttr);
446 m_valueIfDirty = sanitizeValue(valueString); 446 m_valueIfDirty = sanitizeValue(valueString);
447 } else 447 } else
448 updateValueIfNeeded(); 448 updateValueIfNeeded();
449 449
450 m_needsToUpdateViewValue = true; 450 m_needsToUpdateViewValue = true;
451 m_inputTypeView->updateView(); 451 m_inputTypeView->updateView();
452 452
453 if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttr ibutes()) { 453 if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttr ibutes()) {
454 ASSERT(elementData()); 454 ASSERT(elementData());
455 if (const Attribute* height = getAttributeItem(heightAttr)) 455 if (const Attribute* height = findAttributeByName(heightAttr))
456 attributeChanged(heightAttr, height->value()); 456 attributeChanged(heightAttr, height->value());
457 if (const Attribute* width = getAttributeItem(widthAttr)) 457 if (const Attribute* width = findAttributeByName(widthAttr))
458 attributeChanged(widthAttr, width->value()); 458 attributeChanged(widthAttr, width->value());
459 if (const Attribute* align = getAttributeItem(alignAttr)) 459 if (const Attribute* align = findAttributeByName(alignAttr))
460 attributeChanged(alignAttr, align->value()); 460 attributeChanged(alignAttr, align->value());
461 } 461 }
462 462
463 if (document().focusedElement() == this) 463 if (document().focusedElement() == this)
464 document().updateFocusAppearanceSoon(true /* restore selection */); 464 document().updateFocusAppearanceSoon(true /* restore selection */);
465 465
466 setChangedSinceLastFormControlChangeEvent(false); 466 setChangedSinceLastFormControlChangeEvent(false);
467 467
468 addToRadioButtonGroup(); 468 addToRadioButtonGroup();
469 469
(...skipping 1388 matching lines...) Expand 10 before | Expand all | Expand 10 after
1858 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1858 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1859 } 1859 }
1860 #endif 1860 #endif
1861 1861
1862 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue) 1862 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue)
1863 { 1863 {
1864 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ; 1864 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ;
1865 } 1865 }
1866 1866
1867 } // namespace 1867 } // namespace
OLDNEW
« no previous file with comments | « Source/core/dom/NamedNodeMap.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698