Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/core/inspector/DOMPatchSupport.cpp

Issue 313973003: Rename ElementData's attribute related methods for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/parser/HTMLConstructionSite.cpp ('k') | Source/core/xml/XPathFunctions.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 if (!oldNode->isElementNode()) 184 if (!oldNode->isElementNode())
185 return true; 185 return true;
186 186
187 // Patch attributes 187 // Patch attributes
188 Element* oldElement = toElement(oldNode); 188 Element* oldElement = toElement(oldNode);
189 Element* newElement = toElement(newNode); 189 Element* newElement = toElement(newNode);
190 if (oldDigest->m_attrsSHA1 != newDigest->m_attrsSHA1) { 190 if (oldDigest->m_attrsSHA1 != newDigest->m_attrsSHA1) {
191 // FIXME: Create a function in Element for removing all properties. Take in account whether did/willModifyAttribute are important. 191 // FIXME: Create a function in Element for removing all properties. Take in account whether did/willModifyAttribute are important.
192 if (oldElement->hasAttributesWithoutUpdate()) { 192 if (oldElement->hasAttributesWithoutUpdate()) {
193 while (oldElement->attributeCount()) { 193 while (oldElement->attributeCount()) {
194 const Attribute& attribute = oldElement->attributeItem(0); 194 const Attribute& attribute = oldElement->attributeAt(0);
195 if (!m_domEditor->removeAttribute(oldElement, attribute.localNam e(), exceptionState)) 195 if (!m_domEditor->removeAttribute(oldElement, attribute.localNam e(), exceptionState))
196 return false; 196 return false;
197 } 197 }
198 } 198 }
199 199
200 // FIXME: Create a function in Element for copying properties. cloneData FromElement() is close but not enough for this case. 200 // FIXME: Create a function in Element for copying properties. cloneData FromElement() is close but not enough for this case.
201 if (newElement->hasAttributesWithoutUpdate()) { 201 if (newElement->hasAttributesWithoutUpdate()) {
202 AttributeIteratorAccessor attributes = newElement->attributesIterato r(); 202 AttributeIteratorAccessor attributes = newElement->attributesIterato r();
203 AttributeConstIterator end = attributes.end(); 203 AttributeConstIterator end = attributes.end();
204 for (AttributeConstIterator it = attributes.begin(); it != end; ++it ) { 204 for (AttributeConstIterator it = attributes.begin(); it != end; ++it ) {
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 void DOMPatchSupport::dumpMap(const ResultMap& map, const String& name) 511 void DOMPatchSupport::dumpMap(const ResultMap& map, const String& name)
512 { 512 {
513 fprintf(stderr, "\n\n"); 513 fprintf(stderr, "\n\n");
514 for (size_t i = 0; i < map.size(); ++i) 514 for (size_t i = 0; i < map.size(); ++i)
515 fprintf(stderr, "%s[%lu]: %s (%p) - [%lu]\n", name.utf8().data(), i, map [i].first ? nodeName(map[i].first->m_node).utf8().data() : "", map[i].first, map [i].second); 515 fprintf(stderr, "%s[%lu]: %s (%p) - [%lu]\n", name.utf8().data(), i, map [i].first ? nodeName(map[i].first->m_node).utf8().data() : "", map[i].first, map [i].second);
516 } 516 }
517 #endif 517 #endif
518 518
519 } // namespace WebCore 519 } // namespace WebCore
520 520
OLDNEW
« no previous file with comments | « Source/core/html/parser/HTMLConstructionSite.cpp ('k') | Source/core/xml/XPathFunctions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698