Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: Source/core/dom/Attr.cpp

Issue 313973003: Rename ElementData's attribute related methods for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/Element.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2012 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2012 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 { 195 {
196 if (m_element) 196 if (m_element)
197 return m_element->getAttribute(qualifiedName()); 197 return m_element->getAttribute(qualifiedName());
198 return m_standaloneValueOrAttachedLocalName; 198 return m_standaloneValueOrAttachedLocalName;
199 } 199 }
200 200
201 Attribute& Attr::elementAttribute() 201 Attribute& Attr::elementAttribute()
202 { 202 {
203 ASSERT(m_element); 203 ASSERT(m_element);
204 ASSERT(m_element->elementData()); 204 ASSERT(m_element->elementData());
205 return *m_element->ensureUniqueElementData().getAttributeItem(qualifiedName( )); 205 return *m_element->ensureUniqueElementData().findAttributeByName(qualifiedNa me());
206 } 206 }
207 207
208 void Attr::detachFromElementWithValue(const AtomicString& value) 208 void Attr::detachFromElementWithValue(const AtomicString& value)
209 { 209 {
210 ASSERT(m_element); 210 ASSERT(m_element);
211 m_standaloneValueOrAttachedLocalName = value; 211 m_standaloneValueOrAttachedLocalName = value;
212 m_element = nullptr; 212 m_element = nullptr;
213 } 213 }
214 214
215 void Attr::attachToElement(Element* element, const AtomicString& attachedLocalNa me) 215 void Attr::attachToElement(Element* element, const AtomicString& attachedLocalNa me)
216 { 216 {
217 ASSERT(!m_element); 217 ASSERT(!m_element);
218 m_element = element; 218 m_element = element;
219 m_standaloneValueOrAttachedLocalName = attachedLocalName; 219 m_standaloneValueOrAttachedLocalName = attachedLocalName;
220 } 220 }
221 221
222 void Attr::trace(Visitor* visitor) 222 void Attr::trace(Visitor* visitor)
223 { 223 {
224 visitor->trace(m_element); 224 visitor->trace(m_element);
225 ContainerNode::trace(visitor); 225 ContainerNode::trace(visitor);
226 } 226 }
227 227
228 } 228 }
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698