Source/core/html/HTMLSelectElement.cpp - Issue 313973003: Rename ElementData's attribute related methods for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 313973003: Rename ElementData's attribute related methods for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index 98423ca129562d96abcaaabceb1bef8c0aebdcd3..8cce578bce62d3fccef78664a89583d060d69c56 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -323,7 +323,7 @@ void HTMLSelectElement::parseAttribute(const QualifiedName& name, const AtomicSt

AtomicString attrSize = AtomicString::number(size);

if (attrSize != value) {

// FIXME: This is horribly factored.

- if (Attribute* sizeAttribute = ensureUniqueElementData().getAttributeItem(sizeAttr))

+ if (Attribute* sizeAttribute = ensureUniqueElementData().findAttributeByName(sizeAttr))

sizeAttribute->setValue(attrSize);

}

size = max(size, 1);