Refactor PermissionsData pt1

chrome/browser/extensions/api/web_request/web_request_permissions.cc

Index: chrome/browser/extensions/api/web_request/web_request_permissions.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions.cc b/chrome/browser/extensions/api/web_request/web_request_permissions.cc
index 2625c2088324fcc7dea8147da06f7fe0ec87e737..5d0d7a8f1f6f4c7aba7e95cb43343da0f719e854 100644
--- a/chrome/browser/extensions/api/web_request/web_request_permissions.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_permissions.cc
@@ -133,13 +133,15 @@ bool WebRequestPermissions::CanExtensionAccessURL(
       // about: URLs are not covered in host permissions, but are allowed
       // anyway.
       if (!((url.SchemeIs(content::kAboutScheme) ||
-             extensions::PermissionsData::HasHostPermission(extension, url) ||
+             extensions::PermissionsData::ForExtension(extension)

[not at google - send to devlin, 2014/06/02 23:20:06]

here

[Devlin, 2014/06/03 15:28:21]

Not done. Reusing pointer makes no cases faster and DO_NOT_CHECK_HOST case
slower.

[not at google - send to devlin, 2014/06/03 15:45:16]

fine, but note that I'm not worried about the performance, but rather the
brain-load of seeing the same code repeated.

[Devlin, 2014/06/03 15:48:00]

Agreed, and if it's a wash in speed, no problem, but I'd prefer not to slow it
down (especially when it can be inlined like this).

Also, this will be even better when we just do
extension->active_permissions()->Foo().

+                 ->HasHostPermission(url) ||
              url.GetOrigin() == extension->url()))) {
         return false;
       }
       break;
     case REQUIRE_ALL_URLS:
-      if (!extensions::PermissionsData::HasEffectiveAccessToAllHosts(extension))
+      if (!extensions::PermissionsData::ForExtension(extension)
+               ->HasEffectiveAccessToAllHosts())
         return false;
       break;
   }