Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
index 99b91997024669f80f5edd4062d7c41b12981122..9db073879045493872cf76ef27af9b2cfffd1f29 100644
--- a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
@@ -132,16 +132,19 @@ base::ListValue* ConstructFileSystemList(
MediaGalleriesPermission::CheckParam read_param(
MediaGalleriesPermission::kReadPermission);
- bool has_read_permission = PermissionsData::CheckAPIPermissionWithParam(
- extension, APIPermission::kMediaGalleries, &read_param);
+ bool has_read_permission =
not at google - send to devlin 2014/06/02 23:20:06 here
Devlin 2014/06/03 15:28:21 Done.
+ PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(
+ APIPermission::kMediaGalleries, &read_param);
MediaGalleriesPermission::CheckParam copy_to_param(
MediaGalleriesPermission::kCopyToPermission);
- bool has_copy_to_permission = PermissionsData::CheckAPIPermissionWithParam(
- extension, APIPermission::kMediaGalleries, &copy_to_param);
+ bool has_copy_to_permission =
+ PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(
+ APIPermission::kMediaGalleries, &copy_to_param);
MediaGalleriesPermission::CheckParam delete_param(
MediaGalleriesPermission::kDeletePermission);
- bool has_delete_permission = PermissionsData::CheckAPIPermissionWithParam(
- extension, APIPermission::kMediaGalleries, &delete_param);
+ bool has_delete_permission =
+ PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(
+ APIPermission::kMediaGalleries, &delete_param);
const int child_id = rvh->GetProcess()->GetID();
scoped_ptr<base::ListValue> list(new base::ListValue());
@@ -197,8 +200,9 @@ bool CheckScanPermission(const extensions::Extension* extension,
DCHECK(error);
MediaGalleriesPermission::CheckParam scan_param(
MediaGalleriesPermission::kScanPermission);
- bool has_scan_permission = PermissionsData::CheckAPIPermissionWithParam(
- extension, APIPermission::kMediaGalleries, &scan_param);
+ bool has_scan_permission =
+ PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(
+ APIPermission::kMediaGalleries, &scan_param);
if (!has_scan_permission)
*error = kNoScanPermission;
return has_scan_permission;

Powered by Google App Engine
This is Rietveld 408576698