Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc
index 4bd9fecbb29e6070dd0f156b28b8139a21a655fd..005d58a19060a37cf3bac13bbd03188d68e97d17 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc
@@ -2230,8 +2230,9 @@ bool WebRequestInternalAddEventListenerFunction::RunSync() {
// For this reason we do only a coarse check here to warn the extension
// developer if he does something obviously wrong.
if (!is_web_view_guest &&
- extensions::PermissionsData::GetEffectiveHostPermissions(
- extension).is_empty()) {
+ extensions::PermissionsData::ForExtension(extension)
+ ->GetEffectiveHostPermissions()
+ .is_empty()) {
error_ = keys::kHostPermissionsRequired;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698