Refactor PermissionsData pt1

chrome/browser/extensions/api/web_request/web_request_permissions.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/web_request/web_request_permissions.h"
 
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/extension_renderer_state.h"
 #include "chrome/common/extensions/extension_constants.h"
@@ skipping 115 matching lines @@
   if (crosses_incognito && !extension_info_map->CanCrossIncognito(extension))
     return false;
 
   switch (host_permissions_check) {
     case DO_NOT_CHECK_HOST:
       break;
     case REQUIRE_HOST_PERMISSION:
       // about: URLs are not covered in host permissions, but are allowed
       // anyway.
       if (!((url.SchemeIs(content::kAboutScheme) ||
-             extensions::PermissionsData::HasHostPermission(extension, url) ||
+             extensions::PermissionsData::ForExtension(extension)

[not at google - send to devlin, 2014/06/02 23:20:06]

here

[Devlin, 2014/06/03 15:28:21]

Not done. Reusing pointer makes no cases faster and DO_NOT_CHECK_HOST case
slower.

[not at google - send to devlin, 2014/06/03 15:45:16]

fine, but note that I'm not worried about the performance, but rather the
brain-load of seeing the same code repeated.

[Devlin, 2014/06/03 15:48:00]

Agreed, and if it's a wash in speed, no problem, but I'd prefer not to slow it
down (especially when it can be inlined like this).

Also, this will be even better when we just do
extension->active_permissions()->Foo().

+                 ->HasHostPermission(url) ||
              url.GetOrigin() == extension->url()))) {
         return false;
       }
       break;
     case REQUIRE_ALL_URLS:
-      if (!extensions::PermissionsData::HasEffectiveAccessToAllHosts(extension))
+      if (!extensions::PermissionsData::ForExtension(extension)
+               ->HasEffectiveAccessToAllHosts())
         return false;
       break;
   }
 
   return true;
 }