Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Unified Diff: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
diff --git a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
index b289b8faeab17f393adf2e0c9b5a575eb3ebdcb6..3aee864a93f990c6127442513f8ecde66d4f02e5 100644
--- a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
+++ b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
@@ -74,20 +74,24 @@ TEST_F(BrowserPermissionsPolicyDelegateTest, CanExecuteScriptOnPage) {
// The same call should succeed with a normal process, but fail with a signin
// process.
- EXPECT_TRUE(PermissionsData::CanExecuteScriptOnPage(extension.get(),
- kSigninUrl,
- kSigninUrl,
- -1,
- NULL,
- normal_process.GetID(),
- &error)) << error;
- EXPECT_FALSE(PermissionsData::CanExecuteScriptOnPage(extension.get(),
- kSigninUrl,
- kSigninUrl,
- -1,
- NULL,
- signin_process.GetID(),
- &error)) << error;
+ EXPECT_TRUE(PermissionsData::ForExtension(extension)
not at google - send to devlin 2014/06/02 23:20:06 here
Devlin 2014/06/03 15:28:21 Done.
+ ->CanExecuteScriptOnPage(extension,
+ kSigninUrl,
+ kSigninUrl,
+ -1,
+ NULL,
+ normal_process.GetID(),
+ &error))
+ << error;
+ EXPECT_FALSE(PermissionsData::ForExtension(extension)
+ ->CanExecuteScriptOnPage(extension,
+ kSigninUrl,
+ kSigninUrl,
+ -1,
+ NULL,
+ signin_process.GetID(),
+ &error))
+ << error;
}
#endif

Powered by Google App Engine
This is Rietveld 408576698