Revert of Revision Info into GenericSet

Revert of Revision Info into GenericSet (patchset #3 id:40001 of https://codereview.chromium.org/2990293002/ )

Reason for revert:
This CL may have introduced broken tests in the dashboard that are blocking the CQ

Original issue's description:
> Revision Info into GenericSet
> 
> This is part of the effort to move some of our diagnostics into
> GenericSet diagnostics rather than being their own type when appropriate.
> 
> This CL converts the RevisionInfo diagnostic class into a few Generic Sets:
> one each for the fields of Chromium Revision, Chromium commits, V8 Revisions,
> V8 Commits, Catapult Revision, Angle Revisions, Skia Revisions, Webrtv
> Revisions.
> 
> 
> The same removal process has been done for MergedRevisionInfo, since that
> is not necessary anymore.
> 
> Among other things, this CL:
> * Removes the RevisionInfo Diagnostic class from both Python and JS
>   implementations.
> 
> * Removes RevisionInfo and MergedRevisionInfo from all_diagnostics.
> 
> * Changes diagnostic instantiation in add_revision_info to use
>   GenericSets and HistogramSet's AddSharedDiagnostic, replacing
>   RevisionInfo and using Vinn, respectively.
> 
> * Removes RevisionInfo from being one of the SparseDiagnostics
>   types.
> 
> * Removes UI implementations in Tracing for RevisionInfo and
>   MergedRevionInfo.
> 
> * Remove RevisionInfo from add_histogram and respective tests,
>   also adding the logic to adapt to it. Same is done with
>   add_histogram_queue
> 
> * Removes documentation regarding RevisiomInfo.
> 
> BUG=catapult:#3758, catapult:#3507
> 
> Review-Url: https://codereview.chromium.org/2990293002
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b0531f7a731c861783a4c71cb47302bf7164a3fe

TBR=eakuefner@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#3758, catapult:#3507

Review-Url: https://codereview.chromium.org/2999663002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4dd91f2eab39ceb3e98164215865731aa13d3af0

[phsilva, 2017-08-09 01:44:45]

The CQ bit was checked by phsilva@google.com

[phsilva, 2017-08-09 01:44:45]

Created Revert of Revision Info into GenericSet

[commit-bot: I haz the power, 2017-08-09 01:44:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-09 01:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-09 01:44:54]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-catapult-committers".
Note that this has nothing to do with OWNERS files.

[nednguyen, 2017-08-09 01:45:26]

nednguyen@google.com changed reviewers:
+ nednguyen@google.com

[nednguyen, 2017-08-09 01:45:27]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-08-09 01:45:27]

lgtm

[commit-bot: I haz the power, 2017-08-09 01:45:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-09 01:45:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1502243127010870, "parent_rev":
"f62d597f2ef814d043cdc089b23989253579c0e8", "commit_rev":
"4dd91f2eab39ceb3e98164215865731aa13d3af0"}

[commit-bot: I haz the power, 2017-08-09 01:45:45]

Description was changed from

==========
Revert of Revision Info into GenericSet (patchset #3 id:40001 of
https://codereview.chromium.org/2990293002/ )

Reason for revert:
This CL may have introduced broken tests in the dashboard that are blocking the
CQ

Original issue's description:
> Revision Info into GenericSet
> 
> This is part of the effort to move some of our diagnostics into
> GenericSet diagnostics rather than being their own type when appropriate.
> 
> This CL converts the RevisionInfo diagnostic class into a few Generic Sets:
> one each for the fields of Chromium Revision, Chromium commits, V8 Revisions,
> V8 Commits, Catapult Revision, Angle Revisions, Skia Revisions, Webrtv
> Revisions.
> 
> 
> The same removal process has been done for MergedRevisionInfo, since that
> is not necessary anymore.
> 
> Among other things, this CL:
> * Removes the RevisionInfo Diagnostic class from both Python and JS
>   implementations.
> 
> * Removes RevisionInfo and MergedRevisionInfo from all_diagnostics.
> 
> * Changes diagnostic instantiation in add_revision_info to use
>   GenericSets and HistogramSet's AddSharedDiagnostic, replacing
>   RevisionInfo and using Vinn, respectively.
> 
> * Removes RevisionInfo from being one of the SparseDiagnostics
>   types.
> 
> * Removes UI implementations in Tracing for RevisionInfo and
>   MergedRevionInfo.
> 
> * Remove RevisionInfo from add_histogram and respective tests,
>   also adding the logic to adapt to it. Same is done with
>   add_histogram_queue
> 
> * Removes documentation regarding RevisiomInfo.
> 
> BUG=catapult:#3758, catapult:#3507
> 
> Review-Url: https://codereview.chromium.org/2990293002
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

TBR=eakuefner@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#3758, catapult:#3507
==========

to

==========
Revert of Revision Info into GenericSet (patchset #3 id:40001 of
https://codereview.chromium.org/2990293002/ )

Reason for revert:
This CL may have introduced broken tests in the dashboard that are blocking the
CQ

Original issue's description:
> Revision Info into GenericSet
> 
> This is part of the effort to move some of our diagnostics into
> GenericSet diagnostics rather than being their own type when appropriate.
> 
> This CL converts the RevisionInfo diagnostic class into a few Generic Sets:
> one each for the fields of Chromium Revision, Chromium commits, V8 Revisions,
> V8 Commits, Catapult Revision, Angle Revisions, Skia Revisions, Webrtv
> Revisions.
> 
> 
> The same removal process has been done for MergedRevisionInfo, since that
> is not necessary anymore.
> 
> Among other things, this CL:
> * Removes the RevisionInfo Diagnostic class from both Python and JS
>   implementations.
> 
> * Removes RevisionInfo and MergedRevisionInfo from all_diagnostics.
> 
> * Changes diagnostic instantiation in add_revision_info to use
>   GenericSets and HistogramSet's AddSharedDiagnostic, replacing
>   RevisionInfo and using Vinn, respectively.
> 
> * Removes RevisionInfo from being one of the SparseDiagnostics
>   types.
> 
> * Removes UI implementations in Tracing for RevisionInfo and
>   MergedRevionInfo.
> 
> * Remove RevisionInfo from add_histogram and respective tests,
>   also adding the logic to adapt to it. Same is done with
>   add_histogram_queue
> 
> * Removes documentation regarding RevisiomInfo.
> 
> BUG=catapult:#3758, catapult:#3507
> 
> Review-Url: https://codereview.chromium.org/2990293002
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

TBR=eakuefner@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#3758, catapult:#3507

Review-Url: https://codereview.chromium.org/2999663002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-09 01:45:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...