Chromium Code Reviews Chromium Code Reviews
Issue
2990293002:
Revision Info into GenericSet (Closed)
DescriptionRevision Info into GenericSet
This is part of the effort to move some of our diagnostics into
GenericSet diagnostics rather than being their own type when appropriate.
This CL converts the RevisionInfo diagnostic class into a few Generic Sets:
one each for the fields of Chromium Revision, Chromium commits, V8 Revisions,
V8 Commits, Catapult Revision, Angle Revisions, Skia Revisions, Webrtv
Revisions.
The same removal process has been done for MergedRevisionInfo, since that
is not necessary anymore.
Among other things, this CL:
* Removes the RevisionInfo Diagnostic class from both Python and JS
implementations.
* Removes RevisionInfo and MergedRevisionInfo from all_diagnostics.
* Changes diagnostic instantiation in add_revision_info to use
GenericSets and HistogramSet's AddSharedDiagnostic, replacing
RevisionInfo and using Vinn, respectively.
* Removes RevisionInfo from being one of the SparseDiagnostics
types.
* Removes UI implementations in Tracing for RevisionInfo and
MergedRevionInfo.
* Remove RevisionInfo from add_histogram and respective tests,
also adding the logic to adapt to it. Same is done with
add_histogram_queue
* Removes documentation regarding RevisiomInfo.
BUG=catapult:#3758, catapult:#3507
Review-Url: https://codereview.chromium.org/2990293002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b0531f7a731c861783a4c71cb47302bf7164a3fe
Review-Url: https://codereview.chromium.org/2990293002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/665c758fc9cc78b97c5097d21de50493065e00fb
Patch Set 1 #
Total comments: 6
Patch Set 2 : Address Ben's comments #
Total comments: 2
Patch Set 3 : Address Ethan's comments #Patch Set 4 : Rebase on master #Messages
Total messages: 19 (9 generated)
|
