Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: tracing/tracing/value/histogram.py

Issue 2999663002: Revert of Revision Info into GenericSet (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/diagnostics/revision_info.html ('k') | tracing/tracing/value/histogram_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram.py
diff --git a/tracing/tracing/value/histogram.py b/tracing/tracing/value/histogram.py
index 7b8f5eef66109c65db18fc9d0a990de376b21140..e53e05a388e379e20b271268a05f207d125f9a27 100644
--- a/tracing/tracing/value/histogram.py
+++ b/tracing/tracing/value/histogram.py
@@ -724,6 +724,66 @@
@property
def log_uri(self):
return self._log_uri
+
+
+class RevisionInfo(diagnostic.Diagnostic):
+
+ def __init__(self, info):
+ super(RevisionInfo, self).__init__()
+ self._chromium_commit_position = info.get('chromiumCommitPosition', None)
+ self._v8_commit_position = info.get('v8CommitPosition', None)
+ self._chromium = info.get('chromium', [])
+ self._v8 = info.get('v8', [])
+ self._catapult = info.get('catapult', [])
+ self._angle = info.get('angle', [])
+ self._skia = info.get('skia', [])
+ self._webrtc = info.get('webrtc', [])
+
+ @property
+ def chromium_commit_position(self):
+ return self._chromium_commit_position
+
+ @property
+ def v8_commit_position(self):
+ return self._v8_commit_position
+
+ @property
+ def v8(self):
+ return self._v8
+
+ @property
+ def catapult(self):
+ return self._catapult
+
+ @property
+ def angle(self):
+ return self._angle
+
+ @property
+ def skia(self):
+ return self._skia
+
+ @property
+ def webrtc(self):
+ return self._webrtc
+
+ @property
+ def chromium(self):
+ return self._chromium
+
+ def _AsDictInto(self, d):
+ d['chromiumCommitPosition'] = self._chromium_commit_position
+ d['v8CommitPosition'] = self._v8_commit_position
+ d['chromium'] = self._chromium
+ d['v8'] = self.v8
+ d['catapult'] = self.catapult
+ d['angle'] = self.angle
+ d['skia'] = self.skia
+ d['webrtc'] = self.webrtc
+
+ @staticmethod
+ def FromDict(d):
+ return RevisionInfo(d)
# TODO(benjhayden): Unify this with telemetry's IterationInfo.
@@ -1585,6 +1645,7 @@
'Breakdown': Breakdown,
'GenericSet': GenericSet,
'RelatedHistogramSet': RelatedHistogramSet,
+ 'RevisionInfo': RevisionInfo,
'UnmergeableDiagnosticSet': UnmergeableDiagnosticSet,
'RelatedEventSet': RelatedEventSet,
'BuildbotInfo': BuildbotInfo,
« no previous file with comments | « tracing/tracing/value/diagnostics/revision_info.html ('k') | tracing/tracing/value/histogram_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698