Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: tracing/tracing/value/add_revision_info.py

Issue 2999663002: Revert of Revision Info into GenericSet (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tracing/trace_viewer.gypi ('k') | tracing/tracing/value/diagnostics/all_diagnostics.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 import json
6 import tempfile
7
8 from tracing.value import add_shared_diagnostic
9
10 def AddRevisionInfo(histograms_json_filename, chromium, v8, catapult, angle,
11 skia, webrtc):
12 revision_info = {
13 'chromium': chromium,
14 'v8': v8,
15 'catapult': catapult,
16 'angle': angle,
17 'skia': skia,
18 'webrtc': webrtc,
19 }
20
21 with tempfile.NamedTemporaryFile() as diagnostic_file:
22 json.dump(revision_info, diagnostic_file)
23 return add_shared_diagnostic.AddSharedDiagnostic(
24 histograms_json_filename, 'revisions', diagnostic_file.name)
OLDNEW
« no previous file with comments | « tracing/trace_viewer.gypi ('k') | tracing/tracing/value/diagnostics/all_diagnostics.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698